[8.3.0] Fix Arbitrary file access during archive extraction (Zip Slip) on DirectoryWriter
#26091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel/third_party/java/proguard/proguard6.2.2/src/proguard/io/ZipFileDataEntry.java
Line 57 in a9dc595
Fix the issue need to validate the file paths constructed from zip entry names to ensure they remain within the intended base directory. This can be achieved by normalizing the constructed file path and verifying that it starts with the normalized base directory path. If the validation fails, an exception should be thrown to prevent unsafe file operations.
The fix involves:
getFile
method inDirectoryWriter
to validate the constructed file path.File.getCanonicalFile()
to normalize paths and ensure the constructed path is within the base directory.References
Zip Slip Vulnerability
Path Traversal
CWE-22