Added BBF hook to adjust numeric result to correct scale #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-postgresql#529) For Babelfish, the expected behaviour should be for every arithmetic computation which results in numeric datatype, the result should be adjusted(truncated/rounded) to the correct scale. To get this behaviour added hooks at following places to adjust the result value. evaluate_expr() - All the arithmetic computations that result in constant value, happens here. So added a hook to adjust the result after every such arithmetic computation. ExecInterpExpr() - All the arithmetic computations other than mentioned above, happens here. So added a hook to adjust the result after every such arithmetic computation. finalize_aggregate() - For aggregate functions, the final result is computed here, so added a hook to adjust the result for aggregate functions. Also, for some nodes such as T_OpExpr, T_DistinctExpr, T_CoerceViaIO the result_typmod was directly hardcoded as -1 in PostgreSQL, Added hook pltsql_exprTypmod_hook to compute the typmod of the expression and passed those instead of -1 to avoid losing typmod information. added pltsql_exprTypmod_hook to compute expression typmod for expressions whose typmod is not computed by exprTypmod. During initialisation of resulttype in function ExecInitResultTypeTL added hook ExecUpdateResultTypeTL_hook to set correct typmod of all attributes of result tuple. Extension PR: babelfish-for-postgresql/babelfish_extensions#3455 Issues Resolved BABEL-5467
shah-nirmit
approved these changes
Apr 3, 2025
jsudrik
merged commit 1959e62
into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Babelfish, the expected behaviour should be for every arithmetic computation which results in numeric datatype, the result should be adjusted(truncated/rounded) to the correct scale. To get this behaviour added hooks at following places to adjust the result value.
Also,
T_OpExpr, T_DistinctExpr, T_CoerceViaIOthe result_typmod was directly hardcoded as-1in PostgreSQL, Added hookpltsql_exprTypmod_hookto compute the typmod of the expression and passed those instead of-1to avoid losing typmod information.pltsql_exprTypmod_hookto compute expression typmod for expressions whose typmod is not computed byexprTypmod.ExecInitResultTypeTLadded hookExecUpdateResultTypeTL_hookto set correct typmod of all attributes of result tuple.Extension PR: babelfish-for-postgresql/babelfish_extensions#3648
Cherry-picked from: #529
Issues Resolved
BABEL-5467
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.