Dummy PR to test fix for BABEL-5703 #558
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deepesh125
commented
Mar 31, 2025
Comment on lines
620
to
+635
| if (get_rel_persistence(rte->relid) == RELPERSISTENCE_TEMP) | ||
| { | ||
| /* | ||
| * Babelfish Temp tables are created under ENRs which is not | ||
| * shared with other backend (with parallel workwer for example). | ||
| * Here, we are marking rte->relpersistence = RELPERSISTENCE_TEMP | ||
| * for Babelfish temp table so that we can avoid rechecking the | ||
| * permission check of Babelfish temp table on Parallel worker. | ||
| * This is safe because scanning of temp table won't be done | ||
| * under parallel worker. And we have to wait til all the | ||
| * optimisation and rewriting is done. | ||
| */ | ||
| if (sql_dialect == SQL_DIALECT_TSQL) | ||
| rte->relpersistence = RELPERSISTENCE_TEMP; | ||
| return; | ||
| } |
There was a problem hiding this comment.
This is probably not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.