-
Notifications
You must be signed in to change notification settings - Fork 71
Add transactional support for ENR temp tables #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transactional support for ENR temp tables #348
Conversation
6466c67
to
e045dd2
Compare
25d9e2a
to
b6141f0
Compare
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
ENRDropEntry Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
{ | ||
EphemeralNamedRelation tmp_enr = (EphemeralNamedRelation) (lc); | ||
|
||
if (strcmp(enr->md.name, tmp_enr->md.name) == 0 && tmp_enr->md.dropped_subid == enr->md.dropped_subid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that we are handling this during rollback itself, we can skip this optimisation in favour of simplicity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, fixed. Noting that surendra has approved PR (in case this gets lost due to force push).
Signed-off-by: Tim Chang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at notes seems Surendra has approved this one.
1d1b547
into
babelfish-for-postgresql:BABEL_4_X_DEV__PG_16_X
This PR adds tests for babelfish-for-postgresql/postgresql_modified_for_babelfish#348 Issues Resolved: BABEL-4864 Signed-off-by: Tim Chang <[email protected]>
…ostgresql#348) Add transactional support for ENR temp tables Issues Resolved: BABEL-4864 Signed-off-by: Tim Chang <[email protected]>
…ostgresql#348) Add transactional support for ENR temp tables Issues Resolved: BABEL-4864 Signed-off-by: Tim Chang <[email protected]>
…ostgresql#348) Add transactional support for ENR temp tables Issues Resolved: BABEL-4864 Signed-off-by: Tim Chang <[email protected]>
Description
ENR temp tables were not sensitive to transactional behavior. We add it here by introducing a new structure which will track uncommitted ENR tuples and process them accordingly, depending on if the active transaction is committed or rolled back.
Tests are added in babelfish-for-postgresql/babelfish_extensions#2522
Issues Resolved
BABEL-4864
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.