Add transactional support for ENR temp tables #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
timchang514
force-pushed
the
BABEL-4864
branch
5 times, most recently
from
6466c67 to
e045dd2
Compare
timchang514
force-pushed
the
BABEL-4864
branch
3 times, most recently
from
25d9e2a to
b6141f0
Compare
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
ENRDropEntry Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
Signed-off-by: Tim Chang <[email protected]>
surendravishnoi
previously approved these changes
May 22, 2024
| { | ||
| EphemeralNamedRelation tmp_enr = (EphemeralNamedRelation) (lc); | ||
|
|
||
| if (strcmp(enr->md.name, tmp_enr->md.name) == 0 && tmp_enr->md.dropped_subid == enr->md.dropped_subid) |
There was a problem hiding this comment.
given that we are handling this during rollback itself, we can skip this optimisation in favour of simplicity
There was a problem hiding this comment.
Ack, fixed. Noting that surendra has approved PR (in case this gets lost due to force push).
Signed-off-by: Tim Chang <[email protected]>
1 task
lejaokri
approved these changes
May 22, 2024
1 task
forestkeeper
approved these changes
May 22, 2024
forestkeeper
merged commit 1d1b547
into
babelfish-for-postgresql:BABEL_4_X_DEV__PG_16_X
2 checks passed
forestkeeper
pushed a commit
to babelfish-for-postgresql/babelfish_extensions
that referenced
this pull request
May 22, 2024
This PR adds tests for babelfish-for-postgresql/postgresql_modified_for_babelfish#348 Issues Resolved: BABEL-4864 Signed-off-by: Tim Chang <[email protected]>
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 15, 2024
…ostgresql#348) Add transactional support for ENR temp tables Issues Resolved: BABEL-4864 Signed-off-by: Tim Chang <[email protected]>
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 18, 2024
…ostgresql#348) Add transactional support for ENR temp tables Issues Resolved: BABEL-4864 Signed-off-by: Tim Chang <[email protected]>
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 18, 2024
…ostgresql#348) Add transactional support for ENR temp tables Issues Resolved: BABEL-4864 Signed-off-by: Tim Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ENR temp tables were not sensitive to transactional behavior. We add it here by introducing a new structure which will track uncommitted ENR tuples and process them accordingly, depending on if the active transaction is committed or rolled back.
Tests are added in babelfish-for-postgresql/babelfish_extensions#2522
Issues Resolved
BABEL-4864
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.