Support CTE/JOIN usage for PIVOT operator #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhfanhe
reviewed
Jan 26, 2024
RIC06X
force-pushed
the
pivot-view-fix-pg16
branch
from
42050d7 to
4497316
Compare
RIC06X
changed the title
RIC06X
force-pushed
the
pivot-view-fix-pg16
branch
3 times, most recently
from
96d91da to
14cae9f
Compare
RIC06X
force-pushed
the
pivot-view-fix-pg16
branch
from
14cae9f to
359ad18
Compare
RIC06X
force-pushed
the
pivot-view-fix-pg16
branch
4 times, most recently
from
983a0a0 to
3a02cde
Compare
RIC06X
changed the title
This commit fixed an issue that view cannot be created or used by stmt with pivot operator. Task: BABEL-4673 Signed-off-by: Yanjie Xu <[email protected]>
Modified internal PIVOT information analyzer -> executor passing design. Supported CTE/VIEW/JOIN as well as function/procedure for PIVOT operator. Task: BABEL-4713, BABEL-4714, BABEL-4673 Signed-off-by: Yanjie Xu <[email protected]>
Disable CREATE VIEW ON stmt with PIVOT operator due to pg_dump cannot dump pivot view with correct dependency and newly added fields in FuncExpr casued readFunc failed to parse previous minor version string parsetree during select from view after mVU. Task: BABEL-4673 Signed-off-by: Yanjie Xu <[email protected]>
Removed newly added pivot fields in fcinfo and set the fcinfo->context to pivot data when the FuncExpr is a bbf_pivot function Task: BABEL-4673 Signed-off-by: Yanjie Xu <[email protected]>
RIC06X
force-pushed
the
pivot-view-fix-pg16
branch
from
3a02cde to
3fd80cb
Compare
xhfanhe
reviewed
Apr 25, 2024
src/include/fmgr.h
Outdated
| @@ -18,6 +18,7 @@ | |||
| #ifndef FMGR_H | |||
| #define FMGR_H | |||
|
|
|||
| #include "nodes/pg_list.h" | |||
There was a problem hiding this comment.
fmgr.h is a header file used by execSRF.c. And List hasn't been used in execSRF.c until we added our pivot logic. So we need to include this to fmgr.h
RIC06X
force-pushed
the
pivot-view-fix-pg16
branch
2 times, most recently
from
357858f to
3fd80cb
Compare
Replaced pivot related fields with generic Node * field in FuncCall and FuncExpr Task: BABEL-4713, BABEL-4714 Signed-off-by: Yanjie Xu <[email protected]>
Move executor pivot data passing code to Babelfish hook function. Task: BABEL-4713, BABEL-4714 Signed-off-by: Yanjie Xu <[email protected]>
xhfanhe
approved these changes
Apr 26, 2024
forestkeeper
approved these changes
Apr 27, 2024
forestkeeper
merged commit 4295eb2
into
babelfish-for-postgresql:BABEL_4_X_DEV__PG_16_X
2 checks passed
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 15, 2024
…resql#299) This commit fixed an issue that CTE and JOIN cannot be used with pivot operator. We added 1 field (Node *context) in FuncExpr Struct to store pivot additional information. FuncExpr will carry the pivot information to ExecMakeTableFunctionResult. In this function, we pass the pivot information into two newly added FunctionCallInfo that we can retrieve at bbf_pivot function. Task: BABEL-4713, BABEL-4714, BABEL-4795 Signed-off-by: Yanjie Xu <[email protected]>
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 18, 2024
…resql#299) This commit fixed an issue that CTE and JOIN cannot be used with pivot operator. We added 1 field (Node *context) in FuncExpr Struct to store pivot additional information. FuncExpr will carry the pivot information to ExecMakeTableFunctionResult. In this function, we pass the pivot information into two newly added FunctionCallInfo that we can retrieve at bbf_pivot function. Task: BABEL-4713, BABEL-4714, BABEL-4795 Signed-off-by: Yanjie Xu <[email protected]>
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 18, 2024
…resql#299) This commit fixed an issue that CTE and JOIN cannot be used with pivot operator. We added 1 field (Node *context) in FuncExpr Struct to store pivot additional information. FuncExpr will carry the pivot information to ExecMakeTableFunctionResult. In this function, we pass the pivot information into two newly added FunctionCallInfo that we can retrieve at bbf_pivot function. Task: BABEL-4713, BABEL-4714, BABEL-4795 Signed-off-by: Yanjie Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit fixed an issue that CTE and JOIN cannot be used with pivot operator.
We added 1 field (
Node *context) in FuncExpr Struct to store pivot additional information. FuncExpr will carry the pivot information to ExecMakeTableFunctionResult. In this function, we pass the pivot information into two newly added FunctionCallInfo that we can retrieve at bbf_pivot function.Issues Resolved
Task: BABEL-4713, BABEL-4714, BABEL-4795
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.