creating hook for basetype typmodin in case of dump-restore

Signed-off-by: Tanya Gupta <[email protected]>

Author: Tanya Gupta

src/backend/parser/parse_type.c

@@ -34,6 +34,7 @@ static int32 typenameTypeMod(ParseState *pstate, const TypeName *typeName,
 check_or_set_default_typmod_hook_type check_or_set_default_typmod_hook = NULL;
 validate_var_datatype_scale_hook_type validate_var_datatype_scale_hook = NULL;
 handle_default_collation_hook_type handle_default_collation_hook = NULL;
+handle_basetype_typmodin_hook_type handle_basetype_typmodin_hook = NULL;
 
 /*
  * LookupTypeName
@@ -338,16 +339,11 @@ typenameTypeMod(ParseState *pstate, const TypeName *typeName, Type typ)
 {
 	int32		result;
 	Oid			typmodin;
-	Oid 		typbasetype;
-	Oid 		basetypeid;
-	Oid 		typeoid;
 	Datum	   *datums;
 	int			n;
 	ListCell   *l;
 	ArrayType  *arrtypmod;
 	ParseCallbackState pcbstate;
-	const char *dump_restore = GetConfigOption("babelfishpg_tsql.dump_restore", true, false);
-	HeapTuple	tup;
 
 	/* Return prespecified typmod if no typmod expressions */
 	if (typeName->typmods == NIL)
@@ -366,18 +362,10 @@ typenameTypeMod(ParseState *pstate, const TypeName *typeName, Type typ)
 				 parser_errposition(pstate, typeName->location)));
 
 	typmodin = ((Form_pg_type) GETSTRUCT(typ))->typmodin;
-	typeoid = ((Form_pg_type) GETSTRUCT(typ))->oid;
-	typbasetype = ((Form_pg_type) GETSTRUCT(typ))->typbasetype;
 
-	if (dump_restore && (strcmp(dump_restore, "on") == 0) && !OidIsValid(typmodin) && OidIsValid(typbasetype))
-	{
-		basetypeid = getBaseType(typeoid);
-		tup = SearchSysCache1(TYPEOID, ObjectIdGetDatum(basetypeid));
-		if (!HeapTupleIsValid(tup)) /* should not happen */
-			elog(ERROR, "cache lookup failed for type %u", basetypeid);
-		typmodin = ((Form_pg_type) GETSTRUCT((Type)tup))->typmodin;
-		ReleaseSysCache(tup);
-	}
+	/* Handle the typmodin for domains like smallmoney/money and UDTs on them. */
+	if (handle_basetype_typmodin_hook)
+		(*handle_basetype_typmodin_hook)(typ, &typmodin);
 
 	if (typmodin == InvalidOid)
 		ereport(ERROR,

src/include/parser/parse_type.h

@@ -72,4 +72,11 @@ extern PGDLLEXPORT validate_var_datatype_scale_hook_type validate_var_datatype_s
 typedef Oid (*handle_default_collation_hook_type) (Type typ, bool handle_pg_type);
 extern PGDLLEXPORT handle_default_collation_hook_type handle_default_collation_hook;
 
+/*
+ * Hook to find the typmodin for domains like smallmoney/money
+ * and UDTs created on them, in case of dump_restore.
+ */
+typedef void (*handle_basetype_typmodin_hook_type) (Type typ, Oid *typmodin);
+extern PGDLLEXPORT handle_basetype_typmodin_hook_type handle_basetype_typmodin_hook;
+
 #endif							/* PARSE_TYPE_H */