addressing comment

Tanya Gupta · Tanya Gupta · commit 0b00b52ff824 · 2025-05-26T15:43:37.000Z
Signed-off-by: Tanya Gupta &lt;tanyagp@amazon.com&gt;
diff --git a/src/backend/parser/parse_type.c b/src/backend/parser/parse_type.c
@@ -369,7 +369,7 @@ typenameTypeMod(ParseState *pstate, const TypeName *typeName, Type typ)
 	typeoid = ((Form_pg_type) GETSTRUCT(typ))->oid;
 	typbasetype = ((Form_pg_type) GETSTRUCT(typ))->typbasetype;
 
-	if (dump_restore && (strcmp(dump_restore, "on") == 0) && !typmodin && typbasetype)
+	if (dump_restore && (strcmp(dump_restore, "on") == 0) && !OidIsValid(typmodin) && OidIsValid(typbasetype))
 	{
 		basetypeid = getBaseType(typeoid);
 		tup = SearchSysCache1(TYPEOID, ObjectIdGetDatum(basetypeid));

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ typenameTypeMod(ParseState pstate, const TypeName typeName, Type typ)`
`369`	`369`	`typeoid = ((Form_pg_type) GETSTRUCT(typ))->oid;`
`370`	`370`	`typbasetype = ((Form_pg_type) GETSTRUCT(typ))->typbasetype;`
`371`	`371`
`372`		`- if (dump_restore && (strcmp(dump_restore, "on") == 0) && !typmodin && typbasetype)`
	`372`	`+ if (dump_restore && (strcmp(dump_restore, "on") == 0) && !OidIsValid(typmodin) && OidIsValid(typbasetype))`
`373`	`373`	`{`
`374`	`374`	`basetypeid = getBaseType(typeoid);`
`375`	`375`	`tup = SearchSysCache1(TYPEOID, ObjectIdGetDatum(basetypeid));`