-
Notifications
You must be signed in to change notification settings - Fork 104
Support for weak binding views to allow dropping of underlying objects #3806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
R4hul04
wants to merge
11
commits into
babelfish-for-postgresql:BABEL_5_X_DEV
Choose a base branch
from
amazon-aurora:weak-view
base: BABEL_5_X_DEV
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support for weak binding views to allow dropping of underlying objects #3806
R4hul04
wants to merge
11
commits into
babelfish-for-postgresql:BABEL_5_X_DEV
from
amazon-aurora:weak-view
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Pull Request Test Coverage Report for Build 15571970545Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
and sublinks Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
SCHEMABINDING clause in view definitions Signed-off-by: Rahul Parande <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Babelfish only supports strong binding for views, which prevents dropping or altering referenced objects when views depend on them. This behavior differs from SQL Server, which by default allows dropping underlying tables or views unless WITH SCHEMABINDING is explicitly specified.
With this change, Babelfish now supports configurable view binding modes:
This feature aligns Babelfish more closely with SQL Server's behavior, providing greater flexibility
Key aspects include:
babelfishpg_tsql.weak_view_binding
to control the default binding behavior (default is false)WITH SCHEMABINDING
to create strongly bound views regardless of the GUC settingALTER VIEW
operations in both binding modesIn SQL Server, views are weakly bound by default, allowing underlying objects to be dropped or altered. With our implementation, users can now choose between SQL Server's default behavior (weak binding) or the previously enforced behavior (strong binding).
Important Limitation :
This implementation currently only addresses DROP operations on tables, views as well as ALTER operations on views. ALTER TABLE operations (such as dropping columns or changing data types) are still restricted when dependent views exist, regardless of binding mode. This differs from SQL Server's behavior, where weak binding also allows ALTER operations on referenced objects.
Issues Resolved
BABEL-1660
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.