-
Notifications
You must be signed in to change notification settings - Fork 105
Support for weak binding views to allow dropping of underlying objects #3806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: BABEL_5_X_DEV
Are you sure you want to change the base?
Support for weak binding views to allow dropping of underlying objects #3806
Conversation
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Pull Request Test Coverage Report for Build 15688661888Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
and sublinks Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
SCHEMABINDING clause in view definitions Signed-off-by: Rahul Parande <[email protected]>
contrib/babelfishpg_tsql/src/guc.c
Outdated
DefineCustomBoolVariable("babelfishpg_tsql.weak_view_binding", | ||
gettext_noop("Sets the default binding mode for views."), | ||
gettext_noop("When false (default), views have strong binding which prevents dropping referenced" | ||
"objects. When true, views have weak binding which allows it."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"When true, views have weak binding which allows dropping referenced objects."
contrib/babelfishpg_tsql/src/hooks.c
Outdated
@@ -1,5 +1,5 @@ | |||
#include "postgres.h" | |||
|
|||
#include "guc.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guc.h not supposed to be at this place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the header file declaration
@@ -18,14 +18,17 @@ | |||
#include "catalog/pg_attrdef_d.h" | |||
#include "catalog/pg_authid.h" | |||
#include "catalog/pg_db_role_setting.h" | |||
#include "catalog/pg_depend.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For .h , pls add a comment of which dependent need to introduce a new include .h
contrib/babelfishpg_tsql/src/hooks.c
Outdated
@@ -169,6 +174,12 @@ static void transform_pivot_clause(ParseState *pstate, SelectStmt *stmt); | |||
static void transform_unpivot_clause(ParseState *pstate, SelectStmt *stmt); | |||
static bool transform_unpivot_clause_recursive(Node **node, List **measure_cols, List **unpivot_src_cols); | |||
static List* filter_star_targetlist_for_unpivot(ParseState *pstate, SelectStmt *stmt, List **source_cols); | |||
static bool babelfish_view_repair_hook(Query *parsetree); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's a hook implement, the name of this function should not ends with hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to repair_broken_views()
accordingly during view repair Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
underlying objects Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Description
Currently, Babelfish only supports strong binding for views, which prevents dropping or altering referenced objects when views depend on them. This behavior differs from SQL Server, which by default allows dropping underlying tables or views unless WITH SCHEMABINDING is explicitly specified.
With this change, Babelfish now supports configurable view binding modes:
This feature aligns Babelfish more closely with SQL Server's behavior, providing greater flexibility
Key aspects include:
babelfishpg_tsql.weak_view_binding
to control the default binding behavior (default is false)WITH SCHEMABINDING
to create strongly bound views regardless of the GUC settingALTER VIEW
operations in both binding modesIn SQL Server, views are weakly bound by default, allowing underlying objects to be dropped or altered. With our implementation, users can now choose between SQL Server's default behavior (weak binding) or the previously enforced behavior (strong binding).
Important Limitation :
This implementation currently only addresses DROP operations on tables, views as well as ALTER operations on views. ALTER TABLE operations (such as dropping columns or changing data types) are still restricted when dependent views exist, regardless of binding mode. This differs from SQL Server's behavior, where weak binding also allows ALTER operations on referenced objects.
Issues Resolved
BABEL-1660
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.