Support for weak binding views to allow dropping of underlying objects #3806
+3,628
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2025 21:28
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Pull Request Test Coverage Report for Build 15688661888Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
added 6 commits
June 6, 2025 19:06
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
and sublinks Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
added 3 commits
June 10, 2025 01:02
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
SCHEMABINDING clause in view definitions Signed-off-by: Rahul Parande <[email protected]>
contrib/babelfishpg_tsql/src/guc.c
Outdated
| DefineCustomBoolVariable("babelfishpg_tsql.weak_view_binding", | ||
| gettext_noop("Sets the default binding mode for views."), | ||
| gettext_noop("When false (default), views have strong binding which prevents dropping referenced" | ||
| "objects. When true, views have weak binding which allows it."), |
There was a problem hiding this comment.
"When true, views have weak binding which allows dropping referenced objects."
contrib/babelfishpg_tsql/src/hooks.c
Outdated
| @@ -1,5 +1,5 @@ | |||
| #include "postgres.h" | |||
|
|
|||
| #include "guc.h" | |||
There was a problem hiding this comment.
guc.h not supposed to be at this place.
There was a problem hiding this comment.
Removed the header file declaration
| @@ -18,14 +18,17 @@ | |||
| #include "catalog/pg_attrdef_d.h" | |||
| #include "catalog/pg_authid.h" | |||
| #include "catalog/pg_db_role_setting.h" | |||
| #include "catalog/pg_depend.h" | |||
There was a problem hiding this comment.
For .h , pls add a comment of which dependent need to introduce a new include .h
contrib/babelfishpg_tsql/src/hooks.c
Outdated
| @@ -169,6 +174,12 @@ static void transform_pivot_clause(ParseState *pstate, SelectStmt *stmt); | |||
| static void transform_unpivot_clause(ParseState *pstate, SelectStmt *stmt); | |||
| static bool transform_unpivot_clause_recursive(Node **node, List **measure_cols, List **unpivot_src_cols); | |||
| static List* filter_star_targetlist_for_unpivot(ParseState *pstate, SelectStmt *stmt, List **source_cols); | |||
| static bool babelfish_view_repair_hook(Query *parsetree); | |||
There was a problem hiding this comment.
If it's a hook implement, the name of this function should not ends with hook.
There was a problem hiding this comment.
Changed to repair_broken_views()
added 3 commits
June 13, 2025 20:22
accordingly during view repair Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
added 2 commits
June 16, 2025 18:16
underlying objects Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Babelfish only supports strong binding for views, which prevents dropping or altering referenced objects when views depend on them. This behavior differs from SQL Server, which by default allows dropping underlying tables or views unless WITH SCHEMABINDING is explicitly specified.
With this change, Babelfish now supports configurable view binding modes:
This feature aligns Babelfish more closely with SQL Server's behavior, providing greater flexibility
Key aspects include:
babelfishpg_tsql.weak_view_bindingto control the default binding behavior (default is false)WITH SCHEMABINDINGto create strongly bound views regardless of the GUC settingALTER VIEWoperations in both binding modesIn SQL Server, views are weakly bound by default, allowing underlying objects to be dropped or altered. With our implementation, users can now choose between SQL Server's default behavior (weak binding) or the previously enforced behavior (strong binding).
Important Limitation :
This implementation currently only addresses DROP operations on tables, views as well as ALTER operations on views. ALTER TABLE operations (such as dropping columns or changing data types) are still restricted when dependent views exist, regardless of binding mode. This differs from SQL Server's behavior, where weak binding also allows ALTER operations on referenced objects.
Issues Resolved
BABEL-1660
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.