Address issues with arithmetic, mathematical functions for money/smallmoney #3797

ayushdsh · 2025-05-30T10:29:54Z

Description

Handling overflow and incorrect outputs in case of certain money and smallmoney arithmetic and math functions.

There were certain issues found both w.r.t overflow handling and certain functions and operations giving incorrect result for money and smallmoney datatype. This commit addresses those issues.

Issue #1: Overflow of smallmoney arithmetic leading to TDS hang.
Issue #2: Unhandled overflow cases leading to incorrect output.
Issue #3: Fixeddecimal operators being resolved for smallmoney functions and operations leading to incorrect results.

In this commit, we have added new functions for all smallmoney operators and fixed certain overflows with money (fixeddecimal).

Issues Resolved

BABEL-5745, BABEL-5757, BABEL-5756, BABEL-5747, BABEL-5754

Test Scenarios Covered

Note: testcases are imported from PR-3568

Use case based -
All arithmetic and math functions for money and smallmoney
- with all types of operands and vice-versa
Boundary conditions -
All boundary conditions for overflow
Arbitrary inputs -
Certain arbritrary input tests added
Negative test cases -
Overflow conditions checked which were previously causing protocol hang.
Minor version upgrade tests -
NA
Major version upgrade tests -
NA
Performance tests -
NA
Tooling impact -
NA
Client tests -
NA

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

coveralls · 2025-06-01T08:38:27Z

Pull Request Test Coverage Report for Build 15497840812

Details

285 of 322 (88.51%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 75.58%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contrib/babelfishpg_money/fixeddecimal.c	38	41	92.68%
contrib/babelfishpg_common/src/bit.c	6	12	50.0%
contrib/babelfishpg_money/smallmoney.c	241	269	89.59%

Totals
Change from base Build 15464616681:	0.1%
Covered Lines:	49098
Relevant Lines:	64962

💛 - Coveralls

ayushdsh · 2025-06-02T05:47:55Z

contrib/babelfishpg_money/fixeddecimal.c

+    if (adder != (int64) adder)
+    {
+        ereport(ERROR,
+				(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),
+				 errmsg("fixeddecimal out of range")));
+        /* ensure compiler realizes we mustn't reach the division (gcc bug) */
+        PG_RETURN_NULL();
+    }


This condition and the below condition where we check overflow are required in the following scenario -
When arg2 = INT64_MAX, adder itself overflows and the existing overflow check condition assumes that the adder was always negative. Hence, we first check if the adder overflows and terminate if it does.

ayushdsh · 2025-06-02T05:49:27Z

contrib/babelfishpg_money/fixeddecimal.c

+    if (subtractor != (int64) subtractor)
+    {
+        ereport(ERROR,
+				(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),
+				 errmsg("fixeddecimal out of range")));
+        /* ensure compiler realizes we mustn't reach the division (gcc bug) */
+        PG_RETURN_NULL();
+    }


SImilarly, if arg2 = INT64_MAX, this leads to subtractor overflow and becomes -ve and the overflow check is not correct because it assumes that the arg2 is -ve.

ayushdsh · 2025-06-02T05:50:42Z

contrib/babelfishpg_money/fixeddecimal.c

+    /*
+     division with values > FIXEDDECIMAL_MAX lead to overflow
+     in T-SQL
+    */
+    if (arg1 > FIXEDDECIMAL_MAX)
+    {
+        ereport(ERROR,
+				(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),
+				 errmsg("fixeddecimal out of range")));
+		/* ensure compiler realizes we mustn't reach the division (gcc bug) */
+		PG_RETURN_NULL();
+    }


This is a TSQL behaviour which we did not respect previously. This condition takes care of the same.

ayushdsh · 2025-06-02T06:44:55Z

test/JDBC/expected/babel_varbinary-vu-verify.out

-numeric#!#datetime#!#datetime#!#bigint#!#int#!#smallint#!#smallint#!#money#!#datetime#!#varchar#!#datetime#!#bigint
-100.50#!#1900-04-11 12:00:00.0#!#1900-04-11 12:00:00.0#!#1000#!#100#!#10#!#1#!#100.5000#!#1900-01-01 00:00:00.0#!#0A1A2A3A4-B1B2-C1C2-D1D2-E1E2E3E4E5E6#!#<NULL>#!#0
+numeric#!#datetime#!#smallmoney#!#bigint#!#int#!#smallint#!#smallint#!#money#!#bit#!#varchar#!#datetime#!#bigint
+100.50#!#1900-04-11 12:00:00.0#!#100.5000#!#1000#!#100#!#10#!#1#!#100.5000#!#0#!#0A1A2A3A4-B1B2-C1C2-D1D2-E1E2E3E4E5E6#!#<NULL>#!#0


here the changes are because we introduced new operators for bit. Now, bit + smallmoney results into smallmoney, which previously resulted into datetime and bit + bit results into bit which previously resulted into datetime.

contrib/babelfishpg_common/sql/upgrades/babelfish_common_helper--5.2.0--5.3.0.sql

tanscorpio7 · 2025-06-06T10:23:29Z

test/JDBC/input/money_smallmoney-vu-verify.sql

@@ -0,0 +1,2845 @@
+-- Create test tables


We will also need to create prepare and verify test file for this. Upgrade tests should include

Create views in prepare to cover all operators we are fixing.

Performance - create a table in prepare with money small money datatype. in verify ensure that index scan is picked for queries on these tables when the predicate has this operator. We can also keep changing the type on one end of the operator.

create table t (id int small money) create index idx on t(id) SELECT * FROM t WHERE id (some_operator) (different data types)

…smallmoney arithmetic and math functions. There were certain issues found both w.r.t overflow handling and certain functions and operations giving incorrect result for money and smallmoney datatype. This commit addresses those issues. Issue babelfish-for-postgresql#1: Overflow of smallmoney arithmetic leading to TDS hang. Issue babelfish-for-postgresql#2: Unhandled overflow cases leading to incorrect output. Issue babelfish-for-postgresql#3: Fixeddecimal operators being resolved for smallmoney functions and operations leading to incorrect results. Task: BABEL-5745, BABEL-5757, BABEL-5756, BABEL-5747, BABEL-5754 Signed-off-by: Ayush Shah <[email protected]>

Signed-off-by: Ayush Shah <[email protected]>

tanyagupta17 mentioned this pull request May 30, 2025

Handling CASE expression when one branch is of decimal/numeric and other branch is of smallmoney/money. #3719

Merged

1 task

ayushdsh changed the title ~~Address issues with arithmetic, mathematical and aggregate functions for money/smallmoney~~ Address issues with arithmetic, mathematical functions for money/smallmoney May 31, 2025

ayushdsh marked this pull request as ready for review June 2, 2025 05:43

ayushdsh requested review from rohit01010 and tanscorpio7 June 2, 2025 05:44

ayushdsh commented Jun 2, 2025

View reviewed changes

tanscorpio7 suggested changes Jun 6, 2025

View reviewed changes

ayushdsh added 17 commits June 6, 2025 11:19

Merge changes from upstream

464d572

smallmoney/money issue; commit for generating PR

620f747

fixing functions

f2ee215

ayushdsh closed this Jun 6, 2025

ayushdsh force-pushed the smallmoney-issues-fix branch from 62ee33e to de3d86e Compare June 6, 2025 16:00

ayushdsh reopened this Jun 6, 2025

ayushdsh added 4 commits June 6, 2025 16:27

rectified expected dependency file

ca099e2

Signed-off-by: Ayush Shah <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Address issues with arithmetic, mathematical functions for money/smallmoney #3797

Address issues with arithmetic, mathematical functions for money/smallmoney #3797

Uh oh!

ayushdsh commented May 30, 2025 •

edited

Loading

Uh oh!

coveralls commented Jun 1, 2025 •

edited

Loading

Uh oh!

ayushdsh Jun 2, 2025

Uh oh!

ayushdsh Jun 2, 2025

Uh oh!

ayushdsh Jun 2, 2025

Uh oh!

ayushdsh Jun 2, 2025

Uh oh!

Uh oh!

tanscorpio7 Jun 6, 2025

Uh oh!

Uh oh!

Address issues with arithmetic, mathematical functions for money/smallmoney #3797

Are you sure you want to change the base?

Address issues with arithmetic, mathematical functions for money/smallmoney #3797

Uh oh!

Conversation

ayushdsh commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Test Scenarios Covered

Check List

Uh oh!

coveralls commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 15497840812

Details

💛 - Coveralls

Uh oh!

ayushdsh Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

ayushdsh Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

ayushdsh Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

ayushdsh Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tanscorpio7 Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ayushdsh commented May 30, 2025 •

edited

Loading

coveralls commented Jun 1, 2025 •

edited

Loading