Added support for XML VALUE() datatype method #3771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2025 18:38
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Pull Request Test Coverage Report for Build 15483310692Details
💛 - Coveralls |
Signed-off-by: Rohit Bhagat <[email protected]>
Anikait143
reviewed
May 27, 2025
| @@ -38,6 +38,7 @@ PG_KEYWORD("authorization", AUTHORIZATION, TYPE_FUNC_NAME_KEYWORD) | |||
| PG_KEYWORD("auto", TSQL_AUTO, UNRESERVED_KEYWORD) | |||
| PG_KEYWORD("backward", BACKWARD, UNRESERVED_KEYWORD) | |||
| PG_KEYWORD("base64", TSQL_BASE64, UNRESERVED_KEYWORD) | |||
| PG_KEYWORD("bbf_xmlvalue", TSQL_XML_VALUE, UNRESERVED_KEYWORD) | |||
There was a problem hiding this comment.
Category should be RESERVED_KEYWORD
There was a problem hiding this comment.
why should it be reserved?
added 6 commits
May 29, 2025 08:26
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Deepesh125
reviewed
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we do not support XML
VALUE()Function. This PR adds the support for XMLVALUE()Function.This support is added by rewriting the query as follows
Also, added PostgreSQL grammar which calls internal function
bbf_xmlvalue(xpath, xml_expression)which uses underlying PostgreSQL functionxpath()to get the required output, and also added a typecast on its result to get the result with type as specified in argument.Authored-by: Rohit Bhagat [email protected]
Signed-off-by: Rohit Bhagat [email protected]
Issues Resolved
BABEL-5223
Test Scenarios Covered
Use case based - YES
Boundary conditions - YES
Arbitrary inputs - YES
Negative test cases - YES
Minor version upgrade tests - YES
Major version upgrade tests - YES
Performance tests - NA
Tooling impact - NA
Client tests - NA
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.