Fixing typmod handling for COUNT(*) and COUNT_BIG(*).

[Yvinayak07]

1. Issue:

Recursive calls to resolve_numeric_typmod_from_exp, triggered by the is_numeric_cast condition in T_FuncExpr, failed to handle COUNT(*) and COUNT_BIG(*) operations in the T_Aggref node.

In BBF:

1> select count(*) * 1.00 union select 2.00
2> go
----------------------------------------
                                1.000000
                                2.000000 

In TSQL:

1> select count(*) * 1.00 union select 2.00
2> go

----------------
            1.00
            2.00

2. Changes made to fix the issues

Added handling for COUNT(*) and COUNT_BIG(*) aggregates in T_Aggref node

Issues Resolved

Task: BABEL-5886

Authored-by: yashneet vinayak [email protected]
Signed-off-by: yashneet vinayak [email protected]

Test Scenarios Covered

• Use case based - YES

• Boundary conditions - YES

• Arbitrary inputs -

• Negative test cases -

• Minor version upgrade tests -

• Major version upgrade tests -

• Performance tests -

• Tooling impact -

• Client tests -

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[coveralls]

Pull Request Test Coverage Report for Build 15465254117

Details

• 7 of 9 (77.78%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 75.456%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contrib/babelfishpg_tsql/src/pltsql_coerce.c	7	9	77.78%

Totals
Change from base Build 15464616681:	0.002%
Covered Lines:	48786
Relevant Lines:	64655

---

💛 - Coveralls