-
Notifications
You must be signed in to change notification settings - Fork 104
Added sp_helplogins - stored proc that provides information about logins and users associated with those logins. #3733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: BABEL_5_X_DEV
Are you sure you want to change the base?
Added sp_helplogins - stored proc that provides information about logins and users associated with those logins. #3733
Conversation
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742
run in a multi-db setup
Pull Request Test Coverage Report for Build 15522399581Details
💛 - Coveralls |
test/JDBC/input/storedProcedures/Test-sp_helplogins-vu-verify.mix
Outdated
Show resolved
Hide resolved
test/JDBC/input/storedProcedures/Test-sp_helplogins-vu-verify.mix
Outdated
Show resolved
Hide resolved
contrib/babelfishpg_tsql/sql/upgrades/babelfishpg_tsql--5.2.0--5.3.0.sql
Outdated
Show resolved
Hide resolved
test/python/expected/upgrade_validation/expected_dependency.out
Outdated
Show resolved
Hide resolved
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…db for a specific testcase
…db for a specific testcase
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
@@ -39,6 +39,10 @@ go | |||
drop user guest; | |||
go | |||
|
|||
-- re-enabling connect on guest user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this to fix intermittent test failures which is not related to your changes, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct. In this test, we are removing the guest user but never adding them back. This is to add the guest access back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please think about cherry-picking this stabilizing changes to other branches as well if we are observing the same.
@@ -39,6 +39,10 @@ go | |||
drop user guest; | |||
go | |||
|
|||
-- re-enabling connect on guest user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please think about cherry-picking this stabilizing changes to other branches as well if we are observing the same.
contrib/babelfishpg_tsql/sql/upgrades/babelfishpg_tsql--5.2.0--5.3.0.sql
Show resolved
Hide resolved
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
…smallmoney arithmetic and math functions. There were certain issues found both w.r.t overflow handling and certain functions and operations giving incorrect result for money and smallmoney datatype. This commit addresses those issues. Issue babelfish-for-postgresql#1: Overflow of smallmoney arithmetic leading to TDS hang. Issue babelfish-for-postgresql#2: Unhandled overflow cases leading to incorrect output. Issue babelfish-for-postgresql#3: Fixeddecimal operators being resolved for smallmoney functions and operations leading to incorrect results. Task: BABEL-5745, BABEL-5757, BABEL-5756, BABEL-5747, BABEL-5754 Signed-off-by: Ayush Shah <[email protected]>
…smallmoney arithmetic and math functions. There were certain issues found both w.r.t overflow handling and certain functions and operations giving incorrect result for money and smallmoney datatype. This commit addresses those issues. Issue babelfish-for-postgresql#1: Overflow of smallmoney arithmetic leading to TDS hang. Issue babelfish-for-postgresql#2: Unhandled overflow cases leading to incorrect output. Issue babelfish-for-postgresql#3: Fixeddecimal operators being resolved for smallmoney functions and operations leading to incorrect results. Task: BABEL-5745, BABEL-5757, BABEL-5756, BABEL-5747, BABEL-5754 Signed-off-by: Ayush Shah <[email protected]>
…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>
Description
sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist.
It returns two result sets -
First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role
Task - BABEL-5742
Note
Since sp_helplogins returns two result sets and one of them has a uniquely generated SID, tests for now have been disabled.
Issues Resolved
[List any issues this PR will resolve]
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.