Added sp_helplogins - stored proc that provides information about logins and users associated with those logins. #3733

ayushdsh · 2025-05-01T20:36:40Z

Description

sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist.

It returns two result sets -
First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role

Task - BABEL-5742

Note

Since sp_helplogins returns two result sets and one of them has a uniquely generated SID, tests for now have been disabled.

Issues Resolved

[List any issues this PR will resolve]

Test Scenarios Covered

Use case based -
- Logged-in user is a member of sysadmin role (superuser)
- Logged-in user is a member of securityadmin role
- Logged-in user is a member of securityadmin role and also a member of db_securityadmin or db_accessadmin
- Logged-in user is not a member of securityadmin role
- Login does not have any users
Boundary conditions -
- Parameter passed is an invalid login
Arbitrary inputs -
- Parameter passed is an invalid login
Negative test cases -
- Parameter passed is empty
- Parameter passed contains padded spaces L-R
Minor version upgrade tests -
- NA
Major version upgrade tests -
- NA
Performance tests -
- NA
Tooling impact -
- NA
Client tests -
- NA

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742

run in a multi-db setup

coveralls · 2025-05-01T21:10:35Z

Pull Request Test Coverage Report for Build 15582496067

Details

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.003%) to 75.507%

Files with Coverage Reduction	New Missed Lines	%
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c	2	76.03%

Totals
Change from base Build 15576294290:	-0.003%
Covered Lines:	48819
Relevant Lines:	64655

💛 - Coveralls

test/JDBC/input/storedProcedures/Test-sp_helplogins-vu-verify.mix

test/JDBC/jdbc_schedule

contrib/babelfishpg_tsql/sql/babelfishpg_tsql.sql

contrib/babelfishpg_tsql/sql/upgrades/babelfishpg_tsql--5.2.0--5.3.0.sql

contrib/babelfishpg_tsql/sql/babelfishpg_tsql.sql

out of verify script

rectified tests

test/python/expected/upgrade_validation/expected_dependency.out

…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>

test/JDBC/src/main/java/com/sqlsamples/FilterConditions.java

sumitj824 · 2025-05-28T11:33:12Z

test/JDBC/input/BABEL_GRANT_CONNECT-vu-verify.mix

@@ -39,6 +39,10 @@ go
 drop user guest;
 go

+-- re-enabling connect on guest user


I assume this to fix intermittent test failures which is not related to your changes, right?

That's correct. In this test, we are removing the guest user but never adding them back. This is to add the guest access back

Please think about cherry-picking this stabilizing changes to other branches as well if we are observing the same.

test/JDBC/input/storedProcedures/z_sp_helplogins-vu-prepare.mix

contrib/babelfishpg_tsql/sql/babelfishpg_tsql.sql

.github/composite-actions/dump-restore-util/action.yml

contrib/babelfishpg_tsql/sql/babelfishpg_tsql.sql

HarshLunagariya · 2025-05-29T02:38:26Z

test/JDBC/input/BABEL_GRANT_CONNECT-vu-verify.mix

@@ -39,6 +39,10 @@ go
 drop user guest;
 go

+-- re-enabling connect on guest user


Please think about cherry-picking this stabilizing changes to other branches as well if we are observing the same.

test/JDBC/src/main/java/com/sqlsamples/FilterConditions.java

contrib/babelfishpg_tsql/sql/upgrades/babelfishpg_tsql--5.2.0--5.3.0.sql

test/JDBC/expected/z_sp_helplogins-vu-verify.out

…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>

test/JDBC/expected/z_sp_helplogins-vu-verify.out

…smallmoney arithmetic and math functions. There were certain issues found both w.r.t overflow handling and certain functions and operations giving incorrect result for money and smallmoney datatype. This commit addresses those issues. Issue babelfish-for-postgresql#1: Overflow of smallmoney arithmetic leading to TDS hang. Issue babelfish-for-postgresql#2: Unhandled overflow cases leading to incorrect output. Issue babelfish-for-postgresql#3: Fixeddecimal operators being resolved for smallmoney functions and operations leading to incorrect results. Task: BABEL-5745, BABEL-5757, BABEL-5756, BABEL-5747, BABEL-5754 Signed-off-by: Ayush Shah <[email protected]>

…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>

sumitj824 · 2025-06-10T05:29:17Z

contrib/babelfishpg_tsql/sql/babelfishpg_tsql.sql

+            CAST(LExt.orig_loginname AS sys.SYSNAME) AS LoginName,
+            CAST(UExt2.database_name AS sys.SYSNAME) AS DBName,
+            CAST(UExt1.orig_username AS sys.SYSNAME) AS UserName,
+            CAST('Member of' AS sys.varchar(10)) AS UserOrAlias 


The column type should be char(8), please fix it at other places as well.

sumitj824 · 2025-06-10T05:31:08Z

contrib/babelfishpg_tsql/sql/babelfishpg_tsql.sql

+                WHEN Db.owner COLLATE database_default = LExt.orig_loginname THEN CAST('YES' AS sys.char(5))
+                ELSE CAST('NO' AS sys.char(5))
+            END AS AUser,
+            CAST('NO' AS sys.char(7)) AS ARemote -- Currently we do not support linking local logins to remote logins


I think you missed to fix the column type at other places.

sumitj824 · 2025-06-10T05:32:51Z

contrib/babelfishpg_tsql/sql/babelfishpg_tsql.sql

+            CAST(LExt.orig_loginname AS sys.SYSNAME) AS LoginName,
+            CAST(UExt.database_name AS sys.SYSNAME) AS DBName,
+            CAST(UExt.orig_username AS SYS.SYSNAME) AS UserName,
+            CAST('User' AS sys.char(8)) AS UserOrAlias


I think you missed to fix the column type at other places.

…smallmoney arithmetic and math functions. There were certain issues found both w.r.t overflow handling and certain functions and operations giving incorrect result for money and smallmoney datatype. This commit addresses those issues. Issue babelfish-for-postgresql#1: Overflow of smallmoney arithmetic leading to TDS hang. Issue babelfish-for-postgresql#2: Unhandled overflow cases leading to incorrect output. Issue babelfish-for-postgresql#3: Fixeddecimal operators being resolved for smallmoney functions and operations leading to incorrect results. Task: BABEL-5745, BABEL-5757, BABEL-5756, BABEL-5747, BABEL-5754 Signed-off-by: Ayush Shah <[email protected]>

…information about logins (both SQL and Windows) and users associated with those logins. sp_helplogins [ [ @LoginNamePattern = ] N'LoginNamePattern' ] [ ; ] @LoginNamePattern is sys.sysname, with a default of NULL . If specified, @loginnamepattern must exist. It returns two result sets - First view - information about all logins present on the server. Second view - information about each login and its mapping with a user in a database or its membership with a database-role Task - BABEL-5742 Signed-off-by: Ayush Shah <[email protected]>

ayushdsh added 2 commits May 1, 2025 20:22

Removed tests from singledb-schedule since these tests are expected to

23684fe

run in a multi-db setup

ayushdsh self-assigned this May 1, 2025

ayushdsh requested review from HarshLunagariya and shalinilohia50 May 1, 2025 20:37

ayushdsh marked this pull request as ready for review May 1, 2025 20:38

roshan0708 suggested changes May 4, 2025

View reviewed changes

ayushdsh added 2 commits May 5, 2025 19:31

Addressed comments - improved join conditions, separated prepare script

6b2ddbb

out of verify script

Rectified upgrade scripts

68f7149

ayushdsh closed this May 6, 2025

ayushdsh reopened this May 6, 2025

ayushdsh added 5 commits May 6, 2025 03:38

Removing upgrade script to test test-failures

f442c91

Added prepare script to ignore in jdbc_schedule

89a9344

Added view all_database_users to expected of upgrade validation

5d9038d

Added wrapper around original stored proc to reduce duplication and

55db312

rectified tests

Removed view from expected of upgrade validation

2f1dc51

ayushdsh closed this May 6, 2025

ayushdsh reopened this May 6, 2025

ayushdsh added 3 commits May 6, 2025 15:33

Rectified testcases

8ccfbc0

Rectified jdbc_schedule

f48e50c

Added internal view to expected upgrade and sql validation

df98409

ayushdsh commented May 6, 2025

View reviewed changes

test/python/expected/upgrade_validation/expected_dependency.out Outdated Show resolved Hide resolved

ayushdsh closed this May 6, 2025

ayushdsh reopened this May 6, 2025

Trying to rectify tests

9bc8e3b

ayushdsh closed this May 7, 2025

ayushdsh reopened this May 7, 2025

ayushdsh added 2 commits May 7, 2025 05:36

Rectified to fix database collation failures

5d695e2

Rectified testcases and added test for internal views

fd42f89

Merge branch 'babelfish-for-postgresql:BABEL_5_X_DEV' into babel-5742

976e4ec

ayushdsh closed this May 26, 2025

ayushdsh reopened this May 26, 2025

ayushdsh closed this May 27, 2025

ayushdsh reopened this May 27, 2025

roshan0708 reviewed May 28, 2025

View reviewed changes

test/JDBC/src/main/java/com/sqlsamples/FilterConditions.java Show resolved Hide resolved

sumitj824 reviewed May 28, 2025

View reviewed changes

HarshLunagariya reviewed May 29, 2025

View reviewed changes

ayushdsh added 6 commits May 29, 2025 15:46

Merge branch 'babelfish-for-postgresql:BABEL_5_X_DEV' into babel-5742

e878316

testing dump-restore

03f3072

HarshLunagariya suggested changes Jun 3, 2025

View reviewed changes

test/JDBC/expected/z_sp_helplogins-vu-verify.out Outdated Show resolved Hide resolved

ayushdsh added 3 commits June 3, 2025 07:18

HarshLunagariya approved these changes Jun 4, 2025

View reviewed changes

ayushdsh added 2 commits June 9, 2025 02:16

Merge branch 'babelfish-for-postgresql:BABEL_5_X_DEV' into babel-5742

c39bb30

ayushdsh closed this Jun 9, 2025

ayushdsh reopened this Jun 9, 2025

sumitj824 reviewed Jun 10, 2025

View reviewed changes

ayushdsh added 3 commits June 10, 2025 06:10

ayushdsh closed this Jun 11, 2025

ayushdsh reopened this Jun 11, 2025

Added sp_helplogins - stored proc that provides information about logins and users associated with those logins. #3733

Are you sure you want to change the base?

Added sp_helplogins - stored proc that provides information about logins and users associated with those logins. #3733

Conversation

ayushdsh commented May 1, 2025

Description

Note

Issues Resolved

Test Scenarios Covered

Check List

Uh oh!

coveralls commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 15582496067

Details

💛 - Coveralls

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sumitj824 May 28, 2025

Choose a reason for hiding this comment

Uh oh!

ayushdsh May 28, 2025

Choose a reason for hiding this comment

Uh oh!

HarshLunagariya May 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HarshLunagariya May 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sumitj824 Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

sumitj824 Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

sumitj824 Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coveralls commented May 1, 2025 •

edited

Loading