Skip to content

Release 3.56 #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 192 commits into
base: release-3.50
Choose a base branch
from
Draft

Release 3.56 #5427

wants to merge 192 commits into from

Conversation

andrewyuq
Copy link
Contributor

Testing only draft PR

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

rli and others added 28 commits February 11, 2025 15:20
…cies (#5329)

ui-tests-starter attempts to resolve the IDE distribution and fails, but it should not actually be required to build/execute
…on (#5347)

config(amazonq): customization override should respect users' selection 

---------

Co-authored-by: Richard Li <[email protected]>
* Correcting auth checks for /test workflow
)

* fix(amazonq): single click or select through arrow keys on review code issues does not focus code editor to line nor show issue details

* add change report

* add back modelzonemarket.cs file

* deleted irrelevant comment

---------

Co-authored-by: Tai Lai <[email protected]>
It is easy to forget to update all artifacts on a new MV, so consolidate all artifacts under same matrix
Attempt to enforce more consistency on commit messages
… client from AwsClientManager (#5331)

* No need to store a client as a state within this class, AwsClientManager already handle the connection change

resolving comments #5290 (comment)
…o user-selected region (#5365)

WARN - software.aws.toolkits.jetbrains.core.credentials.AwsConnectionManager - Using activeRegion when region is null, calling code needs to be migrated to handle null
java.lang.IllegalStateException
	at software.aws.toolkits.jetbrains.core.credentials.AwsConnectionManager.getActiveRegion(AwsConnectionManager.kt:224)
	at software.aws.toolkits.jetbrains.core.credentials.AwsConnectionManagerKt.activeRegion(AwsConnectionManager.kt:370)
	at migration.software.aws.toolkits.jetbrains.services.telemetry.TelemetryService.record(TelemetryService.kt:59)
	at software.aws.toolkits.telemetry.SessionTelemetry.start(SessionTelemetry.kt:287)
	at software.aws.toolkits.telemetry.SessionTelemetry.start$default(SessionTelemetry.kt:271)
	at software.aws.toolkits.jetbrains.services.telemetry.AwsToolkitStartupMetrics.execute$lambda$0(AwsToolkitStartupMetrics.kt:14)
	at com.intellij.ide.util.RunOnceUtilKt.doRunOnce(RunOnceUtil.kt:68)
	at com.intellij.ide.util.RunOnceUtilKt.access$doRunOnce(RunOnceUtil.kt:1)
Since 2.0, logs are isolated by platform/version pair
)

Previously, UTG did not have telemetry to collect user feedback on generated unit tests. This PR introduces telemetry support to address that gap. Additionally, it enables users to submit comments, which will be routed to a private SIM folder.
…mework (#5385)

Force resolve 243.21565.192 -> 243.21565.193
```
org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find any version that matches com.jetbrains.intellij.java:java-test-framework:{strictly [243, 243.21565.192]; prefer 243.21565.192}.
Versions that do not match:
  - 243.24978.46
  - 243.23654.189
  - 243.23654.153
  - 243.23654.117
  - 243.22562.218
  - + 124 more
```
* Adding truncation logic to testGen user prompt

* Adding change log

* Updating telemetry error message to align VSC and JB

* Removing unwanted files
…5360)

* fix(amazonq): update logic for converting gitignore pattern to regex

* fix(amazonq): update logic for converting gitignore pattern to regex

---------

Co-authored-by: Gaurav Gandhi <[email protected]>
Co-authored-by: Richard Li <[email protected]>
* fix tab acceptAction not working in JB remote

* use isRunningOnRemoteBackend
Copy link

Qodana Community for JVM

35 new problems were found

Inspection name Severity Problems
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 22
Unused symbol 🔶 Warning 4
Component/Action not registered 🔶 Warning 1
Incorrect string capitalization 🔶 Warning 1
Const property naming convention ◽️ Notice 4
Function or property has platform type ◽️ Notice 1
Join declaration and assignment ◽️ Notice 1
Class member can have 'private' visibility ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@@ -15,6 +16,8 @@
import software.aws.toolkits.jetbrains.services.amazonqCodeTest.session.Session
import software.aws.toolkits.jetbrains.services.amazonqCodeTest.storage.ChatSessionStorage
import software.aws.toolkits.jetbrains.services.cwc.messages.ChatMessageType
import software.aws.toolkits.jetbrains.services.cwc.messages.FollowUp
import software.aws.toolkits.resources.message

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

Remove deprecated symbol import

suspend fun sendChatInputEnabledMessage(isEnabled: Boolean) {
if (isInvalidSession()) return
messagePublisher.publish(ChatInputEnabledMessage(activeCodeTestTabId as String, enabled = isEnabled))

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

No cast needed
tabId = tabId,
messageId = messageId ?: UUID.randomUUID().toString(),
messageType = ChatMessageType.Answer,
message = message("amazonqFeatureDev.follow_instructions_for_authentication"),

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'message(String, vararg Any): String' is deprecated. Use extension-specific localization bundle instead
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.FollowUp
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.FollowUpStatusType
import software.aws.toolkits.jetbrains.services.amazonqDoc.messages.FollowUpTypes
import software.aws.toolkits.resources.message

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

Remove deprecated symbol import

val NEW_SESSION_FOLLOWUPS: List<FollowUp> = listOf(
FollowUp(
pillText = message("amazonqDoc.prompt.reject.new_task"),

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'message(String, vararg Any): String' is deprecated. Use extension-specific localization bundle instead
@@ -694,6 +716,7 @@
"CodeWhisperer user action performed",
CodeWhispererUserActionListener::class.java
)
const val MAX_EDIT_SOURCE_DURING_SUGGESTION_PREVIEW = 2

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "MAX_EDIT_SOURCE_DURING_SUGGESTION_PREVIEW" is never used
@@ -95,6 +116,24 @@
state.stringValue[CodeWhispererStringConfigurationType.IgnoredCodeReviewIssues] = value
}

fun isQPrioritizedForTabAccept(): Boolean = state.value.getOrDefault(

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Function "isQPrioritizedForTabAccept" is never used
true
)

fun setQPrioritizedForTabAccept(value: Boolean) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Function "setQPrioritizedForTabAccept" is never used
async { pattern.matches("$relative/") }
}
}
fun ignoreFile(file: VirtualFile, applyExtraBinaryFilesRules: Boolean = true): Boolean = ignoreFile(file.presentableUrl, applyExtraBinaryFilesRules)

Check notice

Code scanning / QDJVMC

Class member can have 'private' visibility Note

Function 'ignoreFile' could be private
package compat.com.intellij.lang.javascript

// probably not necessary, but inline to avoid loading this through core classpath
inline val JavascriptLanguage

Check notice

Code scanning / QDJVMC

Function or property has platform type Note

Declaration has type inferred from a platform call, which can lead to unchecked nullability issues. Specify type explicitly as nullable or non-nullable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.