Skip to content

Add support for service model protocols field #6161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 6, 2025

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented Jun 5, 2025

Motivation and Context

Add support for protocols field in service model which takes list of protocols

Modifications

  • Update codegen ServiceMetadata to add protocols field
  • Add ProtocolUtils class to resolve protocol from protocols and protocol service model fields
    • protocols supersedes protocol
    • Highest priority protocol supported by the SDK that is present in protocols will be selected
    • Priority ordered list in SDK: [ "smithy-rpc-v2-cbor", "json", "rest-json", "rest-xml", "query", "ec2"]
  • Update all usages of ServiceMetadata.getProtocol() to use ProtocolUtils.resolveProtocol()

Testing

  • Added unit test for ProtocolUtils
  • Updated RpcV2 Cbor codegenerated test service model to include multiple values in protocols and removed protocol

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@davidh44 davidh44 requested a review from a team as a code owner June 5, 2025 18:20
@davidh44 davidh44 enabled auto-merge June 5, 2025 22:51
Copy link

sonarqubecloud bot commented Jun 5, 2025

@davidh44 davidh44 added this pull request to the merge queue Jun 5, 2025
Merged via the queue into master with commit d20de2a Jun 6, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants