Fix expiration in past warning from ProfileFileRefresher.

[alextwoods]

Fixes a warning logged from the CachedSupplier used by the ProfileFileRefresher that expiration (stale time) is in the past.

Motivation and Context

ProfileFileSupplier.defaultSupplier() and ProfileFileSupplier.reloadWhenModified() always logs a warning message indicating that the expiration/stale time is in the past. This happens every time the value is accessed from the cache, since we compare clock.instant() calculated at 2 separate instances:

• first in ProfileFileRefresher - https://github.com/aws/aws-sdk-java-v2/blob/master/core/profiles/src/main/java/software/amazon/awssdk/profiles/internal/ProfileFileRefresher.java#L86
• then in CachedSupplier - https://github.com/aws/aws-sdk-java-v2/blob/master/utils/src/main/java/software/amazon/awssdk/utils/cache/CachedSupplier.java#L236

Modifications

This change adds a stale time to now in the ProfileFileRefresher preventing the warning from being logged - and preventing the CachedSupplier from adding 1 second to the stale time when it detects this case.

Does this change any refresh behavior? Does this change when changes in the profile files are reloaded?
No - there should not be behavior changes.
In the current code, the ProfileFileRefresher sets a stale time of now, which always triggers the ProfileFileRefresher to detect a past expiration and adds 1 second to the stale time. This happens even when the values of clock.instant() are identical because the values are checked using isBefore which checks strictly less than and not equal.

This change adds the same 1 second delay to the stale time, but does so explicitly in the ProfileFileRefresher.

Testing

Modified existing test cases. Note that the test cases were incorrectly assuming that the CachedSupplier would use the jitter path - however, jitter is only applied in prefetch cases and when the staleValueBehavior is set to ALLOW - but in the ProfileFileRefresher, prefetch is never done (because prefetch time defaults to Instant.MAX) and staleValueBehavior is always STRICT.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.

License

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud