Skip to content

Use reference of PoolingHttpClientConnectionManager instead of HttpClientConnectionManager for Connection Manager #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joviegas
Copy link
Contributor

Motivation and Context

  • Use reference of PoolingHttpClientConnectionManager instead of HttpClientConnectionManager for Connection Manager
  • PoolingHttpClientConnectionManager has apis related to Closing Idle connections

Modifications

  • Replace references of ConnectionManager as PoolingHttpClientConnectionManager instead of HttpClientConnectionManager

Testing

  • Updated Test case where closeIdle is tested
  • Also tested one-off S3 integ test where initially it was failing for large get/put object

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner May 30, 2025 23:03
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
64.1% Coverage on New Code (required ≥ 80%)
23.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@joviegas joviegas merged commit 13c5796 into feature/master/apache5x Jun 2, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants