Dongie/shared models validation pt3 #6145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for validating models in generator This commit introduces `ModelValidator` which allows us to do validation of the `IntermediateModel` before generation starts; violations are emitted to a `validation-report.json` file under `generated-sources/sdk/models`. As part of this change, `CodeGenerator` was updated to accept `IntermediateModel` as a parameter. This is because all validators operate on the `IntermediateModel`, which already have any SDK specific customizations applied. Since some validators require referencing multiple models, (such as when we start validating shared shapes), having the ability to pass in `IntermediateModel` directly means we only need to build these models once, upfront. * Changelog * Add javadocs
This commit updates the generation mojo to suppport validators: - Add flag for controling whether the validation report is written to disk - Build all models to IntermediateModel upfront - If a service model targets another for sharing shapes, also pass in the target service IntermedidateModel
This validator ensures that when two services share models, any shared model definitions are identical.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License