-
Notifications
You must be signed in to change notification settings - Fork 238
別アカウントの Bedrock を利用するためのクロスアカウント設定を追加 #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ | |
] | ||
}, | ||
"context": { | ||
"ragEnabled": false, | ||
"ragEnabled": true, | ||
"kendraIndexArn": null, | ||
"kendraDataSourceBucketName": null, | ||
"selfSignUpEnabled": true, | ||
|
@@ -48,6 +48,7 @@ | |
"anonymousUsageTracking": true, | ||
"recognizeFileEnabled": false, | ||
"vpcId": null, | ||
"crossAccountBedrockRoleArn": "", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 今までの設定項目と統一して、利用しない場合のデフォルト値を null にしていただいても良いでしょうか? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. null に変更後に再デプロイしたところ、以下のエラーが出力されたのですが、Lambda の環境変数には null は設定できないと理解しました。(認識齟齬ございましたらご指摘ください) nerativeAiUseCasesStack failed: Error [ValidationError]: [/Resources/APIPredict09E4E4FF/Type/Environment/Variables/CROSS_ACCOUNT_BEDROCK_ROLE_ARN] 'null' values are not allowed in templates そのため、空文字列 "" をデフォルト値とできればと思いますが如何でしょうか。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. すみません改めて確認したら全て null というわけではなく空文字もちょくちょく使っていたので、空文字で大丈夫です!:pray: |
||
"@aws-cdk/aws-lambda:recognizeLayerVersion": true, | ||
"@aws-cdk/core:checkSecretUsage": true, | ||
"@aws-cdk/core:target-partitions": [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要なコミットが入っています!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
すみません、修正します!