システムコンテキストの保存機能 #416
Merged
システムコンテキストの保存機能 #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrand
reviewed
Mar 25, 2024
tbrand
requested changes
Mar 26, 2024
Calic0Cat
force-pushed
the
issue-281/system-prompt
branch
from
28ac1d3 to
f054390
Compare
tbrand
reviewed
Apr 2, 2024
| <SystemContextItem | ||
| systemContextTitle={item.systemContextTitle} | ||
| systemContext={item.systemContext} | ||
| key={`${i}`} |
There was a problem hiding this comment.
これ key がないとエラーになりますか？(なくても問題ないように見えました)
There was a problem hiding this comment.
ありがとうございます！
不要でした 🙏
packages/web/src/prompts/index.ts
Outdated
| systemContextTitle: string; | ||
| systemContext: string; | ||
| systemContextId: string; | ||
| }; |
There was a problem hiding this comment.
PrimaryKey があっても特に困らないのであれば types の SystemContext を使いまわした方がシンプルで良いと思いました！
There was a problem hiding this comment.
レビューありがとうございます！
使い回す形で修正しました！
| return null; | ||
| } | ||
| return _systemContextId.split('#')[1]; | ||
| }; |
There was a problem hiding this comment.
実装が chatId と全く同じだと思うので、decomposeChatId を decomposeId とかに rename して使いまわした方が良いと思います！
There was a problem hiding this comment.
レビューありがとうございます！使い回すように変更しました！
tbrand
reviewed
Apr 2, 2024
|
|
||
| type Props = BaseProps & { | ||
| onClick: (params: ChatPageQueryParams) => void; | ||
| systemContextListItem: SystemContextListItem[]; | ||
| onClickDeleteSystemContext: (params: string, index: number) => void; |
tbrand
reviewed
Apr 3, 2024
packages/cdk/cdk.json
Outdated
| @@ -41,7 +41,7 @@ | |||
| "allowedIpV4AddressRanges": null, | |||
| "allowedIpV6AddressRanges": null, | |||
| "allowedCountryCodes": null, | |||
| "dashboard": false, | |||
| "dashboard": true, | |||
There was a problem hiding this comment.
ご指摘ありがとうございます 🙏
修正しました！
added 9 commits
April 3, 2024 10:54
Calic0Cat
force-pushed
the
issue-281/system-prompt
branch
from
d99d745 to
3f8edd2
Compare
tbrand
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #281 , if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.