Skip to content

feat(git hooks): introduce husky #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

Konippi
Copy link
Contributor

@Konippi Konippi commented Apr 20, 2025

Description of Changes

In this PR, by introducing husky, developers can notice that they forgot to run npm run lint at the time of commit.

Checklist

  • Executed npm run lint
  • Modified relevant documentation
  • Verified operation in local environment
  • Executed npm run cdk:test and if there are snapshot differences, execute npm run cdk:test:update-snapshot to update snapshots

Related Issues

N/A

Copy link
Contributor

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. I agree with introducing Husky, but I think it should be introduced more carefully. There are developers of various levels in GenU.
In the documentation, all mentions of npm run lint have been removed, but please explain this more carefully here.
Specifically, I think we need explanations like "npm run lint is now executed when git commit is run, and if it fails, the commit will result in an error like xxx."

@Konippi Konippi force-pushed the feat-introduce-husky branch from 892dfb2 to 2ed9247 Compare April 21, 2025 08:56
@Konippi Konippi requested a review from tbrand April 22, 2025 07:52
@tbrand tbrand merged commit e9964b0 into aws-samples:main Apr 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants