Skip to content

fix: ensure maps of enums are generated properly #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented May 6, 2025

Description of changes:
Currently, generating Maps of Enums was error prone. Instead of generating them.
With these changes, we ensure map[string]Enum are generated properly.

Sample:

f0valf28f0f0 := map[string]svcsdktypes.GlueRecordType{}
for f0valf28f0f0key, f0valf28f0f0valiter := range f0valiter.JDBCConnectorSource.AdditionalOptions.DataTypeMapping {
    var f0valf28f0f0val string
    f0valf28f0f0val = string(*f0valf28f0f0valiter)
    f0valf28f0f0[f0valf28f0f0key] = svcsdktypes.GlueRecordType(f0valf28f0f0val)
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler May 6, 2025 02:04
Copy link

ack-prow bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michaelhtm
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm michaelhtm force-pushed the fix/someissuesforglue branch from e782d8d to 953d030 Compare May 6, 2025 03:32
@michaelhtm michaelhtm changed the title fix: some fixes for Map generation fix: ensure maps of enums are generated properly May 6, 2025
@michaelhtm
Copy link
Member Author

/test s3-controller-test
/test efs-controller-test

Copy link

ack-prow bot commented May 6, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 953d030 link false /test verify-attribution
s3-olm-test 953d030 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member Author

/test s3-controller-test

@rushmash91
Copy link
Member

can we have a description of the issue, small snippets from glue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants