fix: Ignore 422 response while creating commit statuses #299
+112
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragnarpa
force-pushed
the
ignore-422-in-commit-status
branch
from
208181a to
39deccf
Compare
|
@pasha-codefresh, can you review it? |
|
Hey-hey. @pasha-codefresh, any updates? |
|
Hi @pasha-codefresh, I hope you're doing well! It's been over six months since the proposed change was shared. Do you happen to see any issues with it? |
|
@ragnarpa Taking a look |
pasha-codefresh
requested changes
Feb 23, 2025
pkg/controller/controller.go
Outdated
| eventSequence.addError(fmt.Errorf("failed to deliver notification %s to %s: %v using the configuration in namespace %s", trigger, to, err, apiNamespace)) | ||
|
|
||
| var ghErr *services.TooManyCommitStatusesError | ||
| if ok := errors.As(err, &ghErr); ok { |
There was a problem hiding this comment.
I dont really like to have github specific logic here, i think we should create some struct / util that will identify list of errors that we want to treat as warning and not as error , also skip retry. So in future we can just add another error to ignore from another provider here. WDYT?
There was a problem hiding this comment.
Hello @pasha-codefresh, please check again. I tried to keep the changes to a minimum.
ragnarpa
force-pushed
the
ignore-422-in-commit-status
branch
5 times, most recently
from
55d8acc to
ed1e563
Compare
Signed-off-by: Ragnar Paide <[email protected]>
ragnarpa
force-pushed
the
ignore-422-in-commit-status
branch
from
6a7c335 to
8c5380b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore HTTP 422 responses by GitHub while trying to create commit statuses. GitHub limits creating commit statuses to 1000 attempts with the same SHA and context. Currently, when the limit is reached, Argo CD notification controller keeps retrying needlessly which wastes resources. Instead, the notification engine should give up on retrying and signal the caller that the notification attempt has been processed.