Skip to content

Add Flutter SDK avatars and storage service methods to build URLs #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add Flutter SDK avatars and storage service methods to build URLs #495

wants to merge 2 commits into from

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Jul 22, 2022 •
edited
Loading

@stnguyen90 stnguyen90 self-assigned this Jul 22, 2022
@stnguyen90 stnguyen90 requested a review from lohanidamodar July 22, 2022 21:53
@stnguyen90 stnguyen90 force-pushed the feat-71-method-generate-file-url branch from b109bf7 to 5d14088 Compare July 22, 2022 22:07
@stnguyen90 stnguyen90 marked this pull request as draft July 22, 2022 22:12
@stnguyen90
Copy link
Contributor Author

@lohanidamodar, you can focus on this commit for the main change to expose the URLs.

@stnguyen90 stnguyen90 mentioned this pull request Jul 22, 2022
Closed
@stnguyen90 stnguyen90 force-pushed the feat-71-method-generate-file-url branch from 5d14088 to 7d5f897 Compare July 22, 2022 22:39
@stnguyen90 stnguyen90 changed the title Update Flutter SDK storage service to include methods to get URLs Add Flutter SDK avatars and storage service methods to build URLs Jul 22, 2022
@lohanidamodar
Copy link
Member

@lohanidamodar, you can focus on this commit for the main change to expose the URLs.

can't open this link ?

lohanidamodar
lohanidamodar reviewed Jul 27, 2022
View reviewed changes
templates/flutter/lib/services/service.dart.twig
Comment on lines -3 to +2
{% macro method_parameters(parameters, consumes) %}
{% if parameters|length > 0 %}{{ '{' }}{% for parameter in parameters %}{{ _self.parameter(parameter) }}{% if not loop.last %}, {% endif %}{% endfor %}{% if 'multipart/form-data' in consumes %}, Function(UploadProgress)? onProgress{% endif %}{{ '}' }}{% endif %}
{% endmacro %}
{% import 'flutter/base/utils.twig' as utils %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we did not export this to utils, as this macro is used only in this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but since I needed this in templates/flutter/base/requests/location.twig, I thought it would be better to move it to utils.

lohanidamodar
lohanidamodar reviewed Jul 27, 2022
View reviewed changes
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, however, if we do this, we need to do this for all SDKs, not only Flutter. Let's create a new branch, and get this one merged and then work on rest of the SDKs.

@stnguyen90
Copy link
Contributor Author

The changes look good, however, if we do this, we need to do this for all SDKs, not only Flutter. Let's create a new branch, and get this one merged and then work on rest of the SDKs.

Merge this into master now? Or were you thinking of doing all the SDKs in 1 branch before merging into master?

@stnguyen90
Copy link
Contributor Author

@lohanidamodar did you see my last comment?

@lohanidamodar
Copy link
Member

@stnguyen90 keeping this separate until it's done in all the SDKs only then merging to master. Make sure to keep this branch synced to master timely and keep working off of this branch.

@stnguyen90 stnguyen90 closed this Mar 20, 2023
@lohanidamodar lohanidamodar deleted the feat-71-method-generate-file-url branch April 6, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohanidamodar lohanidamodar lohanidamodar left review comments

Assignees

@stnguyen90 stnguyen90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @lohanidamodar