Skip to content

[WIP] Move local resolvers to the link chain #12579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 342 commits into
base: release-4.0
Choose a base branch
from
Draft

[WIP] Move local resolvers to the link chain #12579

wants to merge 342 commits into from
+10,428 −187

Conversation

jerelmiller
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d7ae29b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 22, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@apollo/client@12579

commit: 22399c2

@jerelmiller jerelmiller force-pushed the jerel/stronger-link-context branch from e8051f4 to 63e6df2 Compare April 22, 2025 22:55
@jerelmiller jerelmiller force-pushed the jerel/local-resolvers-link branch 2 times, most recently from 181b3cf to 8310097 Compare April 22, 2025 23:54
Base automatically changed from jerel/stronger-link-context to release-4.0 April 23, 2025 23:09
@jerelmiller
No need for check on alias used for field name on resolver
893ff38
@jerelmiller
Warn when returning undefined
dbc529a
@jerelmiller
just in time fallback for default operation type
a50bda3
@jerelmiller
Only set fallback typename if resolving root field
3869c73
@jerelmiller
Extract to function
0891288
@jerelmiller
Rename variable
7819239
@jerelmiller
Enable failing test
d610373
@jerelmiller
Extract helper to add error
bf27984
@jerelmiller
Add error if __typename not returned from resolver
03e2c1e
@jerelmiller
Remove unused default value for aliased field
e3121e1
@jerelmiller
Update warning message
65117d4
@jerelmiller
Extract helper
ad5d2a1
@jerelmiller
Add test to ensure aliased __typename does return error
fefaabe
@jerelmiller
Only add operation to resolver context
d7d2799
@jerelmiller
Update warning message
055b7d1
@jerelmiller
Add test for query with null data
5daa387
@jerelmiller
Add test for remote errors with no local resolver errors
b8a76c7
@jerelmiller
Add tests for @export resolved fields
82216fd
@jerelmiller
Remove unused import
ed00154
@jerelmiller
Setup start of exporting variables
59f5983
@jerelmiller
Add implementation to add exported variables
fa246bf
@jerelmiller
Minor tweak to test
96e6fc4
@jerelmiller
Fix incorrect assertion
d453be4
@jerelmiller
Tweak teset description
44660c2
@jerelmiller
Add additional codegen config
7206b4b
@jerelmiller
Default args to empty object
0084225
@jerelmiller
Update Resolver types
91de657
@jerelmiller
Add nonOptionalTypename
6f8a0e0
@jerelmiller
Omit scalar resolvers in resolver config
df81fd1
@jerelmiller
Update local resolvers
83aea62
@jerelmiller
Add test file with scalar
0a2d5dc
@jerelmiller
Add additional fixture to ignored files
0c74a78
@jerelmiller
Better match against fixture types
0e5db33
@jerelmiller
Smarter inference on root value type without passing it in
bcf7887
@jerelmiller
Add root value
bd2ad23
@jerelmiller
Add type tests. Improve resolver types
1b0df83
@jerelmiller
More consistent naming
9d7c5d1
@jerelmiller
Remove args
1c2468c
@jerelmiller
Start writing a custom plugin
2848a07
@jerelmiller
Remove some unneeded behavior and options
7095ce4
@jerelmiller
Do more work to make plugin work
cb10f6e
@jerelmiller
Remove more references to federation
8d4d453
@jerelmiller
Don't output scalars in resolver types
117d1df
@jerelmiller
Warn for scalars
ad0e228
@jerelmiller
Update config
e8f4bf3
@jerelmiller
Remove types
b9f03e9
@jerelmiller
Reduce config down
7f50b30
@jerelmiller
Update codegen config
8b21fe6
@jerelmiller
Add extends and simplify
092d4e8
@jerelmiller
Update resolver types in type tests
c45d4c8
@jerelmiller
Remove unused import
02e2870
@jerelmiller
Update type test
bfe48ed
@jerelmiller
Avoid optionals
c0e1077
@jerelmiller
Remove ts resolvers plugin
d7ae29b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jerelmiller