TINKERPOP-3147 Prevent aggregate step from having multiple by modulators #3113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EchoNullify
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3113 +/- ##
============================================
+ Coverage 77.87% 78.10% +0.23%
- Complexity 13578 13750 +172
============================================
Files 1015 1023 +8
Lines 59308 59974 +666
Branches 6835 7004 +169
============================================
+ Hits 46184 46841 +657
+ Misses 10817 10789 -28
- Partials 2307 2344 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update files after merge
|
Reminder: Change PR target to 3.8-dev |
Cole-Greer
reviewed
May 2, 2025
...lin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/Sample.feature
Outdated
Show resolved
Hide resolved
|
VOTE +1 (pending resolution of above comments) |
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TARGET 3.8-dev
https://issues.apache.org/jira/browse/TINKERPOP-3147
Prevent multiple by operators from being used for sample step by throwing IllegalStateException if modulateBy is called more than once.