Prevent multiple by modulators for sack step #3102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VOTE +1 |
1 similar comment
|
VOTE +1 |
andreachild
force-pushed
the
sackMultipleBy
branch
from
bb17b1a to
a4fc8ee
Compare
…eature test to verify the error message received.
andreachild
force-pushed
the
sackMultipleBy
branch
from
a4fc8ee to
caf2259
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.8-dev #3102 +/- ##
==========================================
Coverage ? 76.46%
Complexity ? 13783
==========================================
Files ? 1108
Lines ? 69595
Branches ? 7536
==========================================
Hits ? 53215
Misses ? 13618
Partials ? 2762 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3149
Prevent multiple by operators from being used for the sack count step by throwing IllegalStateException if modulateBy is called more than once.