Skip to content

solves Issue8533 Rerun failed test with maven and junit5 creates the wrong command line. #8545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

homberghp
Copy link
Contributor

This fix reformats the test property passed to the MavenCommandLineExecutor
by replacing occurrences of f.q.c.n.TestClass#f.q.c.n.TestClass.testMethod with
f.q.c.n.TestClass#testMethod.

The location where this fix is applied might not be ideal, because the wrongly formatted test property
is composed elsewhere, however inside the MavenCommandLineExecutor we are sure that it is used for maven.

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. [v ] Was this PR correctly labeled, did the right tests run? When did they run?
  2. [ v] Is this PR squashed?
  3. [ v] Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. [ v] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant