UnusedHint: defer expensive checks until rewrite is performed #8485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UnusedDetector is doing most of this work in findUnused() already - canSafelyRemove() can be likely moved into the rewrite step - text blocks for UnusedTest and minor warnings fixes
mbien
added
Java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnusedDetectoris doing most of this work infindUnused()alreadycanSafelyRemove()can be likely moved into the rewrite stepUnusedTestand minor warnings fixesThis would improve performance of the hint significantly. A synthetic test with 10k unused field is checked in 500ms instead of 20s.
There seems to be some redundancy in what
UnusedDetectordoes and whatcanSafelyRemove()does. I am not completely sure if the additional check is still needed. Draft for now.