Skip to content

gossip: allow multicast addresses for TVU #6415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexpyattaev
Copy link

@alexpyattaev alexpyattaev commented Jun 4, 2025

Problem

  • Currently we block multicast addresses from getting specified for TVU, this makes multicast experiments with turbine impossible

Summary of Changes

  • Allow multicast addresses for TVU
  • Only allow it if port is set to 8002 (so all multicast group members use the same port)

@alexpyattaev alexpyattaev force-pushed the allow_multicast branch 2 times, most recently from d655a26 to 441b3b7 Compare June 4, 2025 19:25
@alexpyattaev alexpyattaev changed the title allow multicast addresses for TVU gossip: allow multicast addresses for TVU Jun 4, 2025
@alexpyattaev alexpyattaev force-pushed the allow_multicast branch 4 times, most recently from b538d1f to 6be7472 Compare June 5, 2025 07:17
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.8%. Comparing base (de54ce0) to head (c5b321c).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6415     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         848      848             
  Lines      379479   379484      +5     
=========================================
- Hits       314550   314511     -39     
- Misses      64929    64973     +44     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants