Skip to content

v2.2: Fix - Reformulates code comment in natural language (backport of #6337) #6405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2.2
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 4, 2025

Problem

See #6217 (comment).

Summary of Changes

Reformulates the code comment in question as natural language.


This is an automatic backport of pull request #6337 done by Mergify.

@mergify mergify bot added the conflicts label Jun 4, 2025
Copy link
Author

mergify bot commented Jun 4, 2025

Cherry-pick of 0c1d60d has failed:

On branch mergify/bp/v2.2/pr-6337
Your branch is up to date with 'origin/v2.2'.

You are currently cherry-picking commit 0c1d60ddd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   programs/bpf_loader/src/lib.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned Lichtso Jun 4, 2025
@mergify mergify bot requested a review from a team as a code owner June 4, 2025 06:52
Copy link
Author

mergify bot commented Jun 4, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the mergify/bp/v2.2/pr-6337 branch from 6f30816 to 24eb1df Compare June 6, 2025 08:45
@Lichtso Lichtso removed the conflicts label Jun 6, 2025
@Lichtso Lichtso requested a review from buffalojoec June 6, 2025 08:46
Reformulates code comment in natural language.

(cherry picked from commit 0c1d60d)
@Lichtso Lichtso force-pushed the mergify/bp/v2.2/pr-6337 branch from 24eb1df to 1f763a4 Compare June 6, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants