Skip to content

enable 0rtt in streamer #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KirillLykov
Copy link

@KirillLykov KirillLykov commented Jun 2, 2025

Problem

Although it is disabled atm, need to investigate a bit more to understand if we need it.

Summary of Changes

Fixes #

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.7%. Comparing base (14e0c98) to head (b796cd0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6377     +/-   ##
=========================================
- Coverage    82.8%    82.7%   -0.1%     
=========================================
  Files         849      849             
  Lines      378868   378865      -3     
=========================================
- Hits       313796   313635    -161     
- Misses      65072    65230    +158     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -86,6 +86,9 @@ pub(crate) fn configure_server(
tls_server_config_builder().with_single_cert(vec![cert], priv_key)?;
server_tls_config.alpn_protocols = vec![ALPN_TPU_PROTOCOL_ID.to_vec()];
server_tls_config.key_log = Arc::new(KeyLogFile::new());
// enable 0rtt on the server side
server_tls_config.max_early_data_size = u32::MAX;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may also need to set initial_max_data to something along the lines of 100 MTUs for this to make a difference in practice (as we'd want to start sending TXs right away, and if we only allow 10 packets to be sent before getting a reply, it will make very little difference).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants