-
Notifications
You must be signed in to change notification settings - Fork 345
TEST branch for updated link and border colours #5867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CharlotteDowns
wants to merge
1
commit into
main
Choose a base branch
from
test-new-link-colours
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 82d37a6 |
Stylesheets changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
index 11acf098a..745e0e0a0 100644
--- a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
+++ b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.css
@@ -61,11 +61,11 @@
}
.govuk-link:visited {
- color: #4c2c92
+ color: #54319f
}
.govuk-link:hover {
- color: #003078
+ color: #0f385c
}
.govuk-link:active,
@@ -146,7 +146,7 @@
}
.govuk-link--no-visited-state:hover {
- color: #003078
+ color: #0f385c
}
.govuk-link--no-visited-state:active,
@@ -779,7 +779,7 @@
}
.govuk-section-break--visible {
- border-bottom: 1px solid #b1b4b6
+ border-bottom: 1px solid #cecece
}
.govuk-button-group {
@@ -1197,7 +1197,7 @@
}
.govuk-frontend-supported .govuk-accordion {
- border-bottom: 1px solid #b1b4b6
+ border-bottom: 1px solid #cecece
}
.govuk-frontend-supported .govuk-accordion__section {
@@ -1355,7 +1355,7 @@
width: 100%;
padding: 10px 0 0;
border: 0;
- border-top: 1px solid #b1b4b6;
+ border-top: 1px solid #cecece;
border-bottom: 10px solid transparent;
color: #0b0c0c;
background: none;
@@ -1512,12 +1512,12 @@
@media (hover:none) {
.govuk-frontend-supported .govuk-accordion__section-header:hover {
- border-top-color: #b1b4b6;
+ border-top-color: #cecece;
box-shadow: inset 0 3px 0 0 #1d70b8
}
.govuk-frontend-supported .govuk-accordion__section-header:hover .govuk-accordion__section-button {
- border-top-color: #b1b4b6
+ border-top-color: #cecece
}
}
@@ -2604,7 +2604,7 @@ screen and (forced-colors:active) {
margin-bottom: 15px;
margin-left: 20px;
padding-left: 35px;
- border-left: 4px solid #b1b4b6
+ border-left: 4px solid #cecece
}
@media (min-width:40.0625em) {
@@ -3011,7 +3011,7 @@ screen and (forced-colors:active) {
@media screen\0 {
.govuk-details {
- border-left: 10px solid #b1b4b6
+ border-left: 10px solid #cecece
}
.govuk-details__summary {
@@ -3042,7 +3042,7 @@ screen and (forced-colors:active) {
}
.govuk-details__summary:hover {
- color: #003078
+ color: #0f385c
}
.govuk-details__summary:focus {
@@ -3108,7 +3108,7 @@ screen and (forced-colors:active) {
}
.govuk-details__text {
- border-left: 5px solid #b1b4b6
+ border-left: 5px solid #cecece
}
}
@@ -3551,7 +3551,7 @@ screen and (forced-colors:active) {
line-height: 1.1428571429;
padding-top: 25px;
padding-bottom: 15px;
- border-top: 1px solid #b1b4b6;
+ border-top: 1px solid #cecece;
color: #0b0c0c;
background: #f3f2f1
}
@@ -3649,7 +3649,7 @@ screen and (forced-colors:active) {
.govuk-footer__section-break {
margin: 0 0 30px;
border: 0;
- border-bottom: 1px solid #b1b4b6
+ border-bottom: 1px solid #cecece
}
@media (min-width:40.0625em) {
@@ -3732,7 +3732,7 @@ screen and (forced-colors:active) {
.govuk-footer__heading {
margin-bottom: 30px;
padding-bottom: 20px;
- border-bottom: 1px solid #b1b4b6
+ border-bottom: 1px solid #cecece
}
@media (max-width:40.0525em) {
@@ -4240,7 +4240,7 @@ screen and (forced-colors:active) {
margin-top: 20px;
margin-bottom: 20px;
clear: both;
- border-left: 10px solid #b1b4b6
+ border-left: 10px solid #cecece
}
@media print {
@@ -4443,7 +4443,7 @@ screen and (forced-colors:active) {
}
.govuk-notification-banner__link:hover {
- color: #003078
+ color: #0f385c
}
.govuk-notification-banner__link:active,
@@ -4704,7 +4704,7 @@ screen and (forced-colors:active) {
}
.govuk-pagination--block .govuk-pagination__prev+.govuk-pagination__next {
- border-top: 1px solid #b1b4b6
+ border-top: 1px solid #cecece
}
.govuk-pagination--block .govuk-pagination__link-title:after {
@@ -4935,7 +4935,7 @@ screen and (forced-colors:active) {
.govuk-phase-banner {
padding-top: 10px;
padding-bottom: 10px;
- border-bottom: 1px solid #b1b4b6
+ border-bottom: 1px solid #cecece
}
.govuk-phase-banner__content {
@@ -5142,7 +5142,7 @@ screen and (forced-colors:active) {
margin-bottom: 15px;
margin-left: 20px;
padding-left: 35px;
- border-left: 4px solid #b1b4b6
+ border-left: 4px solid #cecece
}
@media (min-width:40.0625em) {
@@ -5288,7 +5288,7 @@ screen and (forced-colors:active) {
}
.govuk-service-navigation {
- border-bottom: 1px solid #b1b4b6;
+ border-bottom: 1px solid #cecece;
background-color: #f3f2f1
}
@@ -5392,7 +5392,7 @@ screen and (forced-colors:active) {
}
.govuk-service-navigation__link:hover {
- color: #003078
+ color: #0f385c
}
.govuk-service-navigation__link:active,
@@ -5736,7 +5736,7 @@ screen and (min-width:40.0625em) and (-ms-high-contrast:active) {
}
.govuk-summary-list__row {
- border-bottom: 1px solid #b1b4b6
+ border-bottom: 1px solid #cecece
}
@media (max-width:40.0525em) {
@@ -5840,7 +5840,7 @@ screen and (min-width:40.0625em) and (-ms-high-contrast:active) {
.govuk-summary-list__actions-list-item {
margin-right: 10px;
padding-right: 10px;
- border-right: 1px solid #b1b4b6
+ border-right: 1px solid #cecece
}
.govuk-summary-card__action:last-child,
@@ -5861,7 +5861,7 @@ screen and (min-width:40.0625em) and (-ms-high-contrast:active) {
.govuk-summary-card__action:not(:first-child),
.govuk-summary-list__actions-list-item:not(:first-child) {
- border-left: 1px solid #b1b4b6
+ border-left: 1px solid #cecece
}
.govuk-summary-card__action:first-child,
@@ -5904,7 +5904,7 @@ screen and (min-width:40.0625em) and (-ms-high-contrast:active) {
.govuk-summary-card {
margin-bottom: 20px;
- border: 1px solid #b1b4b6
+ border: 1px solid #cecece
}
@media (min-width:40.0625em) {
@@ -6081,7 +6081,7 @@ screen and (-ms-high-contrast:active) {
.govuk-table__cell,
.govuk-table__header {
padding: 10px 20px 10px 0;
- border-bottom: 1px solid #b1b4b6;
+ border-bottom: 1px solid #cecece;
text-align: left;
vertical-align: top
}
@@ -6297,11 +6297,11 @@ screen and (-ms-high-contrast:active) {
}
.govuk-tabs__tab:visited {
- color: #4c2c92
+ color: #54319f
}
.govuk-tabs__tab:hover {
- color: #003078
+ color: #0f385c
}
.govuk-tabs__tab:active,
@@ -6320,7 +6320,7 @@ screen and (-ms-high-contrast:active) {
.govuk-frontend-supported .govuk-tabs__list {
margin-bottom: 0;
- border-bottom: 1px solid #b1b4b6
+ border-bottom: 1px solid #cecece
}
.govuk-frontend-supported .govuk-tabs__list:after {
@@ -6353,7 +6353,7 @@ screen and (-ms-high-contrast:active) {
margin-top: -5px;
margin-bottom: -1px;
padding: 14px 19px 16px;
- border: 1px solid #b1b4b6;
+ border: 1px solid #cecece;
border-bottom: 0;
background-color: #fff
}
@@ -6412,7 +6412,7 @@ screen and (-ms-high-contrast:active) {
.govuk-frontend-supported .govuk-tabs__panel {
margin-bottom: 0;
padding: 30px 20px;
- border: 1px solid #b1b4b6;
+ border: 1px solid #cecece;
border-top: 0
}
@@ -6471,11 +6471,11 @@ screen and (-ms-high-contrast:active) {
margin-bottom: 0;
padding-top: 10px;
padding-bottom: 10px;
- border-bottom: 1px solid #b1b4b6
+ border-bottom: 1px solid #cecece
}
.govuk-task-list__item:first-child {
- border-top: 1px solid #b1b4b6
+ border-top: 1px solid #cecece
}
.govuk-task-list__item--with-link:hover {
Action run for 82d37a6 |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/settings/_colours-applied.scss b/packages/govuk-frontend/dist/govuk/settings/_colours-applied.scss
index 47822ca70..431762b4f 100644
--- a/packages/govuk-frontend/dist/govuk/settings/_colours-applied.scss
+++ b/packages/govuk-frontend/dist/govuk/settings/_colours-applied.scss
@@ -124,7 +124,7 @@ $govuk-success-colour: govuk-colour("green") !default;
/// @type Colour
/// @access public
-$govuk-border-colour: govuk-colour("mid-grey") !default;
+$govuk-border-colour: #cecece !default;
/// Input border colour
///
@@ -160,14 +160,14 @@ $govuk-link-colour: govuk-colour("blue") !default;
/// @type Colour
/// @access public
-$govuk-link-visited-colour: govuk-colour("purple") !default;
+$govuk-link-visited-colour: #54319f !default;
/// Link hover colour
///
/// @type Colour
/// @access public
-$govuk-link-hover-colour: govuk-colour("dark-blue") !default;
+$govuk-link-hover-colour: #0f385c !default;
/// Active link colour
///
Action run for 82d37a6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A test branch which updates:
#4c2c92
to#54319f
#003078
to#0f385c
and
#b1b4b6
to#cecece
Why
To create a test environment for the proposed new link styles