Skip to content

dns_1984.hosting.sh: fix logging in by updating session cookie name #6296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

paulfertser
Copy link

Since at least Mar 29 the 1984.hosting server doesn't return "sessionid" cookie and apparently "cookie1984nammnamm" is used instead for the same purpose.

This results in errors like this

One or more cookies are empty: 'csrftoken=JTAJf2Roxl3bwNynzKKIroBqjzgi8d87', ''.

and operation fails.

This patch makes DNS TXT method work again with 1984 hosting.

Since at least Mar 29 the 1984.hosting server doesn't return
"sessionid" cookie and apparently "cookie1984nammnamm" is used instead
for the same purpose.

This results in errors like this
```
One or more cookies are empty: 'csrftoken=JTAJf2Roxl3bwNynzKKIroBqjzgi8d87', ''.
```
and operation fails.

This patch makes DNS TXT method work again with 1984 hosting.
Copy link

github-actions bot commented Apr 9, 2025

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@paulfertser
Copy link
Author

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2 We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

Hello dear bot and the maintainers. This is a bugfix, not a new DNS API so the guides do not really apply. I've just tested that it fixes the issue with a real life account locally, is that not enough?

@Neilpang
Copy link
Member

any changes to the hook must pass the test.
please follow the guide.

@paulfertser
Copy link
Author

paulfertser commented Apr 23, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants