Add support for HTTP-01 challenge validation plugin hooks #6289
+509
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
force-pushed
the
http01-pluggable
branch
from
e566691 to
c7106b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I can't use DNS validation, and the server I'm running acme.sh on is not web accessible. This adds the ability to have various plugins for the http-01 validator.
Right now, I've added SCP & Local as plugins, but possible future ones could be S3, GCP Cloud Storage, Azure Blob Storage, etc (for example, in the case you host a static site on an object storage, and need to use http-01 as a validator).
The
localplugin is used solely for testing, and operates pretty much in the same way as the existing webroot functionality.I understand this is a system design change, and it does have implications for the project as a whole, so I do know if it doesn't align with your current roadmap or design. If that's the case, no hard feelings from me, and please feel free to close. I wrote it for myself, but I wanted to share it with the project since I am thankful for your work on this and how it's helped me.
If this is accepted, I can move the README.md from the subdirectory into a new wiki page.