Skip to content

If ACCOUNT_URL is empty when we need it, re-read it. Fixes #1360 #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jim-p
Copy link
Contributor

@jim-p jim-p commented Mar 14, 2018

Fix #1360 by re-reading the account URL if it is empty when needed for ACME v2

@jim-p jim-p mentioned this pull request Mar 14, 2018
@Neilpang
Copy link
Member

but why is ACCOUNT_URL empty here ?

@jim-p
Copy link
Contributor Author

jim-p commented Mar 15, 2018

It may be a quirk of how it is executed on pfSense, in which case I can just keep that fix local there. It almost always fails the first time it is run but works the second time. The difference being that the first time, the account data, csr, keys, etc, have just been written to the filesystem for the first time. When run the second time, those files already exist.

The logs show the ACCOUNT_URL is there earlier in the process, but somehow by the point it is needed, it is no longer set in the environment. Following through the code I didn't see anything obvious that pointed to why, however, but re-reading it worked and seemed like a better solution since it did not rely on something else reading it sooner and happening to place it in the environment.

@Neilpang
Copy link
Member

@jim-p please try again with latest code. it's fixed.

@Neilpang Neilpang deleted the branch acmesh-official:dev January 19, 2022 12:56
@Neilpang Neilpang closed this Jan 19, 2022
@Neilpang Neilpang reopened this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants