added option to set alias for PKCS12 #1289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neilpang
reviewed
Feb 19, 2018
acme.sh
Outdated
| @@ -5746,6 +5748,10 @@ _process() { | |||
| _password="$2" | |||
| shift | |||
| ;; | |||
| --name) | |||
There was a problem hiding this comment.
do not use --name.
use something like: --pfx-alias instead.
Neilpang
reviewed
Feb 19, 2018
acme.sh
Outdated
| @@ -6016,7 +6022,7 @@ _process() { | |||
| uninstallcronjob) uninstallcronjob ;; | |||
| cron) cron ;; | |||
| toPkcs) | |||
| toPkcs "$_domain" "$_password" "$_ecc" | |||
| toPkcs "$_domain" "$_password" "$_name" "$_ecc" | |||
There was a problem hiding this comment.
place the new parameter at the last position.
Neilpang
reviewed
Feb 19, 2018
acme.sh
Outdated
| elif [ "$pfxName" ]; then | ||
| ${ACME_OPENSSL_BIN:-openssl} pkcs12 -export -out "$_cpfx" -inkey "$_ckey" -in "$_ccert" -certfile "$_cca" -password "pass:$pfxPassword" -name "$pfxName" | ||
| ${ACME_OPENSSL_BIN:-openssl} pkcs12 -export -out "$_cpfx" -inkey "$_ckey" -in "$_ccert" -certfile "$_cca" -password "pass:$pfxPassword" -name "$pfxAlias" -caname "$pfxCaname" | ||
| elif [ "$pfxAlias" ]; then |
There was a problem hiding this comment.
I don't understand this change.
Is the pfxName same as pfxAlias ?
There was a problem hiding this comment.
As far as i know the alias field is a unique string to identify the key entry. I am used to oracles keystore tool and oracle named this field alias. I reverted the change.
|
Just seeing that this pull request is still open. Will the changes not be merged? Did I forget something? Is something unclear? |
|
@Neilpang: Is there any way I can help you to get these changes merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to set the alias, so I added this option. Before this the alias was 1 and is still the default with --name parameter.