[test] Remove test/spec/expected-output. NFC #7385
Open
+1
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason these 4 tests had expected output but no others. The spec tests work based on internal assertions so comparing output should not be needed.
tlively
reviewed
Mar 20, 2025
There was a problem hiding this comment.
Looks like this corresponds to the test test/wasm2js/func_ptrs.2asm.js, so I'm not sure it's related to the spec tests at all.
There was a problem hiding this comment.
Oh, but that file is also a test output. Both seem to correspond to test/spec/testsuite/func_ptrs.wast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason these 4 tests had expected output but no others. The spec tests work based on internal assertions so comparing output should not be needed.