-
Notifications
You must be signed in to change notification settings - Fork 3
Update CytoTable Environment File #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CytoTable Environment File #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I only had minor comments, LGTM!
@@ -61,7 +61,6 @@ def __base_exec( | |||
unlock=unlock, | |||
forceall=force, | |||
use_conda=True, | |||
conda_prefix=env_manager, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to open this parameter up to a CytoSnake user (if it isn't already)? Here I'm wondering whether one might want to distinguish between Snakemake defaults for the conda_prefix
(mostly in external compute environments).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configurational.yaml
contains parameters on how to execute workflows. However, there's no set structure yet. That's a good point. I'll make this as a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created issue #57
I have applied all comments and suggestions! Merging. |
About
This is a small PR that updates
CytoSnake's
CytoTable
module.What was changed
cytotable.yaml
file