Skip to content

Update CytoTable Environment File #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 17, 2023

Conversation

axiomcura
Copy link
Member

@axiomcura axiomcura commented May 16, 2023

About

This is a small PR that updates CytoSnake's CytoTable module.

What was changed

  • Removed unnecessary parameters and variables
  • Update cytotable.yaml file

@axiomcura axiomcura marked this pull request as ready for review May 16, 2023 19:38
@axiomcura axiomcura requested a review from d33bs May 16, 2023 22:16
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I only had minor comments, LGTM!

@@ -61,7 +61,6 @@ def __base_exec(
unlock=unlock,
forceall=force,
use_conda=True,
conda_prefix=env_manager,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to open this parameter up to a CytoSnake user (if it isn't already)? Here I'm wondering whether one might want to distinguish between Snakemake defaults for the conda_prefix (mostly in external compute environments).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configurational.yaml contains parameters on how to execute workflows. However, there's no set structure yet. That's a good point. I'll make this as a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue #57

@axiomcura
Copy link
Member Author

I have applied all comments and suggestions! Merging.

@axiomcura axiomcura merged commit 84b2dc6 into WayScience:main May 17, 2023
@axiomcura axiomcura deleted the cytotable-module-update branch May 17, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants