Skip to content

Specify "__Host-" and "__Secure-" prefix failures #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2025
Merged

Conversation

aamuley
Copy link
Collaborator

@aamuley aamuley commented May 20, 2025

Per #248 add the cases where the CookieStore set algorithm would not resolve because of the prefix requirements to the spec. This is tested in the set arguments wpt and the special names wpt

Should this pr additionally change any language in https://wicg.github.io/cookie-store/#prefixes?


Preview | Diff

Copy link
Collaborator

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the non-normative language is still okay. Though I'm not sure "what more widely adopted" is doing there as nobody has plans to change document.cookie that I know of. But that should be addressed separately.

Co-authored-by: Anne van Kesteren <[email protected]>
@aamuley aamuley marked this pull request as ready for review May 21, 2025 13:58
@aamuley aamuley requested a review from annevk May 22, 2025 11:40
Copy link
Collaborator

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay from my perspective, modulo some syntax nits.

@aamuley aamuley requested a review from DCtheTall May 23, 2025 16:09
@aamuley aamuley merged commit 9570d80 into WICG:main May 27, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request May 27, 2025
SHA: 9570d80
Reason: push, by aamuley

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants