-
Notifications
You must be signed in to change notification settings - Fork 36
Specify "__Host-" and "__Secure-" prefix failures #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Anne van Kesteren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the non-normative language is still okay. Though I'm not sure "what more widely adopted" is doing there as nobody has plans to change document.cookie
that I know of. But that should be addressed separately.
Co-authored-by: Anne van Kesteren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay from my perspective, modulo some syntax nits.
SHA: 9570d80 Reason: push, by aamuley Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Per #248 add the cases where the CookieStore set algorithm would not resolve because of the prefix requirements to the spec. This is tested in the set arguments wpt and the special names wpt
Should this pr additionally change any language in https://wicg.github.io/cookie-store/#prefixes?
Preview | Diff