Store user data in request #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonLeary42
force-pushed
the
request-name-volatile
branch
from
b39ba6e to
0b75c4d
Compare
This reverts commit 2966ded.
bryank-cs
reviewed
Jun 7, 2025
| @@ -130,10 +147,26 @@ public function removeRequests($dest = self::REQUEST_BECOME_PI) | |||
| $this->delete(self::TABLE_REQS, ["request_for" => $dest]); | |||
| } | |||
|
|
|||
| public function requestExists($requestor, $dest = self::REQUEST_BECOME_PI) | |||
| public function getRequest($user, $dest) | |||
| { | |||
| $results = $this->search(self::TABLE_REQS, ["request_for" => $dest]); | |||
There was a problem hiding this comment.
Why doesn't this search also filter by $user?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When redis is flushed, the names/emails/orgs of all nonexistent users disappear. Any attempt to approve requests made by these users will result in a white screen of death because the portal doesn't know what name/email/org to write to LDAP.
Solution:
Any access to name/email/org for a nonexistent user is now an error. name/email/org are stored with each request.
Notes:
The request creations now have assertions that
$USERand$SSOmatch. This is to prevent an admin from viewing as another user and accidentally submitting a request for that user with the admin's name/email/org.