Skip to content

catch edge cases #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

catch edge cases #234

wants to merge 2 commits into from

Conversation

simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Jun 3, 2025

#172

once #233 is merged, we can reasonably assume no one will be submitting forms multiple times, so it's easier to justify throwing errors instead of silently failing.

situation behavior before behavior after covered by tests ?
new duplicate group creation request allowed error no
new group creation request but group already exists noop error no
new group creation request but owner requested account deletion noop error no
approve nonexistent group creation request allowed error no
approve group creation request but group already exists noop error no
approve group creation request but owner requested account deletion noop error no
deny group creation request but group already exists noop error no
deny nonexistent group creation request noop log and noop no
cancel nonexistent group join request noop log and noop no
cancel nonexistent group join request error error no
deny nonexistent group join request noop error no
remove absent user from group noop log and noop no
remove group owner from group error error no
new group join request but user already in group log and noop error no
new duplicate group join request log and noop error no
new group join request but user requested account deletion error error no

@simonLeary42 simonLeary42 marked this pull request as draft June 7, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant