"view as user" test, rework uses of die()

[simonLeary42]

• added new helper functions
  • die: does the same thing unless phpunit is running in which case it throws a special exception
  • errorLog: writes to error log including logged in user, IP address, and backtrace
  • badRequest: sends HTTP header 400, writes to error log, and dies
  • forbidden: sends HTTP header 403, writes to error log, and dies
• replaced die() in authorization checks with UnitySite::forbidden
• replaced die() in bad request checks with UnitySite::badRequest
  • send http 400 bad request when headers aren't right #176
• replaced silly redirect/include chainadmin/user-mgmt.php -> panel/ -> panel/index.php -> panel/account.php with a direct link admin/user-mgmt.php -> panel/account.php
• moved the clearView logic in header.php up to the top before nonexistent users are redirected to new_account.php, this allows an admin to viewUser a nonexistent user and not get stuck
  • feature request: spawn temporary blank user accounts #74

testing:

• updated switchUser to prevent tests from polluting each other's sessions
• renamed post to http_post, added http_get
• added a pre-commit hook to make sure that all occurrences of die / exit are replaced with UnitySite::die
• added tests for "view as user" functionality
• modified http_post so that it always discards output
  • the idea was to avoid discarding important error messages, but it's more annoying than anything, interferes with PHPUnit expectException, and hasn't come in handy

pre-commit hook tested:

• exit(), die(), exit, die, die ()
• phpcbf disabled because it automatically turns die () into die()

$ git diff --staged | cat

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index c1d232a..017c363 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -12,14 +12,14 @@ repos:
   #   hooks:
   #     - id: trailing-whitespace
   #     - id: end-of-file-fixer
-  - repo: local
-    hooks:
-      - id: phpcbf
-        name: PHP Code Beautifier and Fixer
-        entry: phpcbf
-        language: system
-        files: \.php$
-        args: [--standard=PSR2, --colors]
+  # - repo: local
+  #   hooks:
+  #     - id: phpcbf
+  #       name: PHP Code Beautifier and Fixer
+  #       entry: phpcbf
+  #       language: system
+  #       files: \.php$
+  #       args: [--standard=PSR2, --colors]

   # linters (work required) ########################################################################
   # - repo: https://github.com/pre-commit/pre-commit-hooks
diff --git a/resources/lib/UnityGroup.php b/resources/lib/UnityGroup.php
index 02b9cbd..ca592c8 100644
--- a/resources/lib/UnityGroup.php
+++ b/resources/lib/UnityGroup.php
@@ -30,7 +30,7 @@ class UnityGroup
     public function __construct($pi_uid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK)
     {
         $this->pi_uid = $pi_uid;
-
+        die();
         $this->LDAP = $LDAP;
         $this->SQL = $SQL;
         $this->MAILER = $MAILER;
diff --git a/resources/lib/UnityLDAP.php b/resources/lib/UnityLDAP.php
index fc44cd4..a2c9dd8 100644
--- a/resources/lib/UnityLDAP.php
+++ b/resources/lib/UnityLDAP.php
@@ -60,7 +60,7 @@ class UnityLDAP extends ldapConn
         $def_user_shell
     ) {
         parent::__construct($host, $dn, $pass);
-
+        exit();
         $this->STR_USEROU = $user_ou;
         $this->STR_GROUPOU = $group_ou;
         $this->STR_PIGROUPOU = $pigroup_ou;
diff --git a/resources/lib/UnityOrg.php b/resources/lib/UnityOrg.php
index 03f8581..ee32011 100644
--- a/resources/lib/UnityOrg.php
+++ b/resources/lib/UnityOrg.php
@@ -17,7 +17,7 @@ class UnityOrg
     public function __construct($orgid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK)
     {
         $this->orgid = $orgid;
-
+        die   ();
         $this->LDAP = $LDAP;
         $this->SQL = $SQL;
         $this->MAILER = $MAILER;
diff --git a/resources/lib/UnitySQL.php b/resources/lib/UnitySQL.php
index c583582..bf916ef 100644
--- a/resources/lib/UnitySQL.php
+++ b/resources/lib/UnitySQL.php
@@ -27,6 +27,7 @@ class UnitySQL

     public function __construct($db_host, $db, $db_user, $db_pass)
     {
+        exit;
         $this->conn = new PDO("mysql:host=" . $db_host . ";dbname=" . $db, $db_user, $db_pass);
         $this->conn->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
     }
diff --git a/resources/lib/UnityUser.php b/resources/lib/UnityUser.php
index a2e839d..1fd4622 100644
--- a/resources/lib/UnityUser.php
+++ b/resources/lib/UnityUser.php
@@ -21,7 +21,7 @@ class UnityUser
     public function __construct($uid, $LDAP, $SQL, $MAILER, $REDIS, $WEBHOOK)
     {
         $this->uid = $uid;
-
+        die;
         $this->LDAP = $LDAP;
         $this->SQL = $SQL;
         $this->MAILER = $MAILER;

simon@wheatley:portal $ git commit -m foobar
PHP CodeSniffer..........................................................Failed
- hook id: phpcs
- exit code: 2

FILE: /Users/simon/unity/portal/resources/lib/UnityOrg.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 20 | ERROR | [x] Space before opening parenthesis of function call prohibited
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------

Time: 92ms; Memory: 10MB

php -l...................................................................Passed
Assert no die()/exit()...................................................Failed
- hook id: assert-no-die-exit
- exit code: 1

die is not allowed! use UnitySite::die() instead.
resources/lib/UnityGroup.php:33:        die();
resources/lib/UnityOrg.php:20:        die   ();
exit is not allowed! use UnitySite::die() instead.
resources/lib/UnityLDAP.php:63:        exit();
resources/lib/UnitySQL.php:30:        exit;
die is not allowed! use UnitySite::die() instead.
resources/lib/UnityUser.php:24:        die;

UnitySite::forbidden tested:

firefox:

chrome:

this page only shows when absolutely nothing was returned by the webserver. if I add echo "<html></html>" before die(), I get a white screen in both chrome and firefox.

and in error log:

[Tue Apr 29 22:37:12.337653 2025] [php:notice] [pid 12] [client 192.168.65.1:26684] forbidden: {"message":"not an admin","REMOTE_USER":"[email protected]","REMOTE_ADDR":"192.168.65.1","trace":"#0 \\/var\\/www\\/unity-web-portal\\/resources\\/lib\\/UnitySite.php(66): UnityWebPortal\\\\lib\\\\UnitySite::errorLog()\\n#1 \\/var\\/www\\/unity-web-portal\\/webroot\\/admin\\/user-mgmt.php(8): UnityWebPortal\\\\lib\\\\UnitySite::forbidden()\\n#2 {main}"}

header.php viewUser/clearUser refactor, silly redirect chain tested:

Screen.Recording.2025-04-30.at.9.44.03.AM.mov