Skip to content

Remove custom shell #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 24, 2025
Merged

Remove custom shell #203

merged 11 commits into from
Apr 24, 2025

Conversation

simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Apr 24, 2025

this is the fun alternative to #200

Fixes a WSOD when a user tries to set their login shell with non ascii characters. Also avoids the LDAP warnings generated in testing: https://github.com/UnityHPC/unity-web-portal/actions/runs/14648366156/job/41108067187

It also grays out the submit button when there's no change.

Screen.Recording.2025-04-24.at.3.34.13.PM.mov

@simonLeary42 simonLeary42 merged commit d9d5b4d into main Apr 24, 2025
2 of 3 checks passed
simonLeary42 added a commit that referenced this pull request Apr 30, 2025
* add check for special characters in login shell

* display invalid reason in <p> like the rest of the page

* remove comment

* update unityuser to do same checks on login shell as frontend does

* update CONTRIBUTING.md

* add check for empty shell

* update tests

* update CONTRIBUTING.md

* remove custom login shell

* remove note from contrib

* update test
@simonLeary42 simonLeary42 deleted the remove-custom-shell branch June 6, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant