Skip to content

add tests for approving, denying PI membership requests #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 30, 2025
Merged

Conversation

simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Apr 22, 2025

  • updated UnityLDAP to use $this->getEntry to take advantage of prevent duplicate LDAPEntries hakasapl/phpopenldaper#7
  • removed php code sniffer ignore lines from test code since all test code is now ignored
  • added tests
    • one is currently failing, UnityGroup::approveUser will work even if there was no request to approve
  • added comment to sql bootstrap on how to create requests

@bryank-cs bryank-cs requested a review from Copilot April 30, 2025 18:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds tests for approving and denying PI membership requests while updating the GitHub workflows to ensure submodules are checked out during CI runs.

  • Added "with: submodules: true" lines in pre-commit, phpunit, and functional workflows to support projects that use submodules.

Reviewed Changes

Copilot reviewed 5 out of 21 changed files in this pull request and generated no comments.

File Description
.github/workflows/pre-commit.yml Enables checkout of submodules
.github/workflows/phpunit.yml Enables checkout of submodules
.github/workflows/functional.yml Enables checkout of submodules for functional tests
Files not reviewed (16)
  • .gitmodules: Language not supported
  • composer.json: Language not supported
  • resources/autoload.php: Language not supported
  • resources/lib/UnityGroup.php: Language not supported
  • resources/lib/UnityLDAP.php: Language not supported
  • resources/lib/UnityOrg.php: Language not supported
  • resources/lib/UnityUser.php: Language not supported
  • test/functional/LoginShellSetTest.php: Language not supported
  • test/functional/PiMemberApproveTest.php: Language not supported
  • test/functional/PiMemberDenyTest.php: Language not supported
  • test/functional/PiRemoveUserTest.php: Language not supported
  • test/phpunit-bootstrap.php: Language not supported
  • test/unit/AjaxSshValidateTest.php: Language not supported
  • test/unit/UnityGithubTest.php: Language not supported
  • tools/docker-dev/sql/bootstrap-users.sql: Language not supported
  • tools/docker-dev/unity-web-portal: Language not supported

@simonLeary42 simonLeary42 force-pushed the testing6 branch 3 times, most recently from 7d2d6dc to 4171c3c Compare April 30, 2025 19:34
@simonLeary42 simonLeary42 merged commit e614cdc into main Apr 30, 2025
2 of 3 checks passed
@simonLeary42 simonLeary42 deleted the testing6 branch June 6, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant