-
Notifications
You must be signed in to change notification settings - Fork 10
reduce size of data types #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think most of these fields could be reduced to 100. This would also allow for tables with multi-column indexes, if needed. |
For usernames in particular I feel like it might be worthwhile to keep more buffer, just in case we get back a really ridiculous eppn from an IDP. 255 maybe? |
|
Spec for EPPN says 128: https://www.educause.edu/fidm/attributes |
reduced to 128. Confirmed that "operator" and "requestor" are uids, which are eppns |
also reduced "operator_ip" to 15 chars, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can merge after change for request_for
Co-authored-by: bryank-cs <[email protected]>
768 is the maximum length that can be used as the primary key in a mariaDB table. using 769, I get this error: