Skip to content

reduce size of data types #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025
Merged

reduce size of data types #125

merged 3 commits into from
Mar 24, 2025

Conversation

simonLeary42
Copy link
Collaborator

768 is the maximum length that can be used as the primary key in a mariaDB table. using 769, I get this error:

#1071 - Specified key was too long; max key length is 3072 bytes 

@bryank-cs
Copy link
Contributor

I think most of these fields could be reduced to 100. This would also allow for tables with multi-column indexes, if needed.

@simonLeary42
Copy link
Collaborator Author

simonLeary42 commented Mar 20, 2025

For usernames in particular I feel like it might be worthwhile to keep more buffer, just in case we get back a really ridiculous eppn from an IDP. 255 maybe?

@simonLeary42
Copy link
Collaborator Author

groupJoinRequests, groupRequests, groupRoleAssignments, groupRoles, groupTypes are probably never going to be used

@bryank-cs
Copy link
Contributor

Spec for EPPN says 128: https://www.educause.edu/fidm/attributes

@simonLeary42
Copy link
Collaborator Author

reduced to 128. Confirmed that "operator" and "requestor" are uids, which are eppns

@simonLeary42
Copy link
Collaborator Author

also reduced "operator_ip" to 15 chars, xxx.xxx.xxx.xxx

@simonLeary42
Copy link
Collaborator Author

#131

Copy link
Contributor

@bryank-cs bryank-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge after change for request_for

@simonLeary42 simonLeary42 merged commit e345c4f into UnityHPC:main Mar 24, 2025
1 of 2 checks passed
@simonLeary42
Copy link
Collaborator Author

#148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants