-
Notifications
You must be signed in to change notification settings - Fork 29
ST6RI-836 Add option that allows changing the API basePath in a running Jupyter kernel #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%api-base-path
is an awkward name for a command. How about something like %repo
instead. The help text should then say:
Usage: %repo [<BASE PATH>]
If <BASE PATH> is not given, print the current repository base path.
If <BASE PATH> is given, set the repository base path.
<BASE PATH> is a URL giving the API base path for the repository access by the %projects, %publish and %load commands.
For example: https://my.domain.com/sysml_repo
- updated help string - fixed '-h' flag
Hi @seidewitz, For the example URL I used the default value (http://sysml2-dev.intercax.com:9000), it's more consistent with the new help strings, and default values we used in ST6RI-178. Also, I removed the part 'The api base path is:' from the output of this command so now it simply prints the current base path. |
I specifically do not want to put a real domain in the help text. The Intercax deployment will not be the default forever, and may even change in the near future. And the default should particularly not be the |
I see. I changed it to the one you wrote. |
In the current implentation of the Jupyter kernel the REST API base path is specified as part of the deployment process: either during the kernel installation by using --api-base-path or by using an environmental variable.
This PR adds the
%api-base-path [<BASE PATH>]
magic command that allows users to change the API base path in the running kernel.