Skip to content

[pull] main from pylint-dev:main #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

[pull] main from pylint-dev:main #41

merged 1 commit into from
May 14, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented May 14, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Standardize and centralize Unknown node instantiation by introducing a shared UNATTACHED_UNKNOWN, updating constructor and context propagation, replacing scattered Unknown() usages across objectmodel and protocols, tightening NodeNG.root(), and adapting tests with a new xfail regression case.

Enhancements:

  • Introduce a global UNATTACHED_UNKNOWN singleton with SYNTHETIC_ROOT parent to standardize Unknown nodes
  • Require parent parameter in Unknown constructor and propagate instance context when creating Unknown in objectmodel
  • Replace ad-hoc Unknown() instances with UNATTACHED_UNKNOWN in inference protocols and tests
  • Tighten NodeNG.root() to only return Module and remove Unknown assertion

Tests:

* add parents to Unknowns in the objectmodel

* restore the invariant of root

* add xfailing "__eval__.get(1)" test

* enforce the correct parent on Unknown nodes
@pull pull bot added the ⤵️ pull label May 14, 2025
@pull pull bot merged commit e7a8669 into Stars1233:main May 14, 2025
Copy link

gitstream-cm bot commented May 14, 2025

🚨 gitStream Monthly Automation Limit Reached 🚨

Your organization has exceeded the number of pull requests allowed for automation with gitStream.
Monthly PRs automated: 2292/250

To continue automating your PR workflows and unlock additional features, please contact LinearB.

Copy link

sourcery-ai bot commented May 14, 2025

Reviewer's Guide

This PR centralizes handling of unknown AST nodes by introducing a shared UNATTACHED_UNKNOWN instance, enforcing explicit parent propagation for Unknown nodes, updating code and tests to use this new constant or supply a parent, refining interpreter objectmodel methods to instantiate Unknown with the correct context, tightening node root typing, and adding a new xfail regression test for eval.get inference.

File-Level Changes

Change Details Files
Refactor Unknown node instantiation and usage
  • Require parent parameter in Unknown constructor and remove default parent argument
  • Introduce UNATTACHED_UNKNOWN=Unknown(parent=SYNTHETIC_ROOT)
  • Replace ad-hoc Unknown() calls with UNATTACHED_UNKNOWN or pass parent where needed
  • Update tests to use SYNTHETIC_ROOT parent for Unknown instances
tests/test_nodes.py
tests/test_regrtest.py
astroid/nodes/node_classes.py
astroid/protocols.py
tests/test_helpers.py
Propagate correct parent in interpreter Unknown returns
  • Modify attr___spec__, attr___loader__, attr___cached__, attr___ne__, attr___annotations__ to pass self._instance as Unknown parent
astroid/interpreter/objectmodel.py
Tighten node_ng root method typing
  • Change root() return type annotation to nodes.Module only
  • Adjust assertion to reflect only Module instances
astroid/nodes/node_ng.py
Add xfail regression test for eval.get inference error
  • Introduce new test_regression_eval_get_of_arg marked xfail raising InferenceError
tests/test_regrtest.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented May 14, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant