-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from pylint-dev:main #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* add parents to Unknowns in the objectmodel * restore the invariant of root * add xfailing "__eval__.get(1)" test * enforce the correct parent on Unknown nodes
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
Reviewer's GuideThis PR centralizes handling of unknown AST nodes by introducing a shared UNATTACHED_UNKNOWN instance, enforcing explicit parent propagation for Unknown nodes, updating code and tests to use this new constant or supply a parent, refining interpreter objectmodel methods to instantiate Unknown with the correct context, tightening node root typing, and adding a new xfail regression test for eval.get inference. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Standardize and centralize Unknown node instantiation by introducing a shared UNATTACHED_UNKNOWN, updating constructor and context propagation, replacing scattered Unknown() usages across objectmodel and protocols, tightening NodeNG.root(), and adapting tests with a new xfail regression case.
Enhancements:
Tests:
eval.__get__(1)
should be an inference error pylint-dev/astroid#2743 ensuring eval.get inference raises InferenceError