Skip to content

This commit removes the duplicate key in MagicNumberTypeHash. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kipcole9
Copy link

@kipcole9 kipcole9 commented Jan 1, 2015

"MZ" is defined twice, once on line 36 and again on line 59.
Ruby 2.2 gives a warning for this (prior versions did not).

This commit comments out the duplicate on line 59.

"MZ" is defined twice, once on line 36 and again on line 59.
Ruby 2.2 gives a warning for this (prior versions did not).

This commit comments out the duplicate on line 59.
@SixArm
Copy link
Collaborator

SixArm commented Jan 4, 2015

Thank you! I'll remove the dup and update the signing key so it works - will do by Monday. If you want/need to reach me before then, I'm [email protected] or joelparkerhenderson on every major chat service.

@SixArm
Copy link
Collaborator

SixArm commented Jan 6, 2015

I've done these:

  • upgraded the version to 2.0.2
  • remove the duplicate "MZ"
  • updated the signing certificate
  • updated the README installation instructions, version, etc.
  • added you, Kip, to the README as a contributor - thank you!

To get the new version:

gem install sixarm_ruby_magic_number_type '=2.0.2'

Can you try this and see if it works for you the way you want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants