[py][BiDi] use constant for LogLevel #15677
Open
+13
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
💥 What does this PR do?
Use typed string for LogLevel which matches the rest bindings
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement, Tests
Description
Introduced
LogLevel
constants for BiDi log levelsUpdated tests to use
LogLevel
constantsImproved consistency with other Selenium bindings
Changes walkthrough 📝
log.py
Add LogLevel constants for BiDi logging
py/selenium/webdriver/common/bidi/log.py
LogLevel
class with log level constantsbidi_script_tests.py
Update BiDi log tests to use LogLevel constants
py/test/selenium/webdriver/common/bidi_script_tests.py
LogLevel
constants in assertionsLogLevel
usage in tests