Skip to content

regression: Sidebar should collapse in tablet view under feature preview only #35872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release-7.6.0
Choose a base branch
from

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 24, 2025

Proposed changes (including videos or screenshots)

Introduced here: #35807

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-66

Copy link

changeset-bot bot commented Apr 24, 2025

⚠️ No Changeset found

Latest commit: 2c4413f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Apr 24, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@dougfabris dougfabris added this to the 7.6.0 milestone Apr 24, 2025
Copy link
Contributor

github-actions bot commented Apr 24, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35872/

Built to branch gh-pages at 2025-04-25 21:14 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.16%. Comparing base (a083701) to head (2c4413f).
Report is 11 commits behind head on release-7.6.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.6.0   #35872   +/-   ##
==============================================
  Coverage          61.16%   61.16%           
==============================================
  Files               3003     3003           
  Lines              71350    71351    +1     
  Branches           16333    16333           
==============================================
+ Hits               43638    43642    +4     
+ Misses             24746    24740    -6     
- Partials            2966     2969    +3     
Flag Coverage Δ
e2e 57.88% <100.00%> (+<0.01%) ⬆️
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris changed the title regression: Sidebar should collapse in tablet view only under feature preview regression: Sidebar should collapse in tablet view under feature preview only Apr 24, 2025
@dougfabris dougfabris marked this pull request as ready for review April 25, 2025 23:07
@dougfabris dougfabris requested a review from a team as a code owner April 25, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant